Fixing remaps and namespaces - #390
Open
Mat198 wants to merge 1 commit into
Open
Conversation
Uses the main python node and parse the data for the internal image_transport node.
Contributor
|
I have already learned to manually resolve the base topic before giving it to image_transport. What you propose seems to be more intuitive (and ROS1-like). I could live with both variants - if the intentional behavior is well documented. Do the maintainers have a stance at which way is the preferred? a) do not remap base topic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adresses issue #357 and also applies a correction for topic remap.
I was in need for this correction on my work so I made this PR without much discussion. I consider this solution as non ideal because it will break everyting using the image_transport_py right now. Anyway, the api is kinda broken as there is not a proper way to remap topics and add namespaces.
Any suggestions are welcome and I hope this PR helps someone :)