Skip to content

Replace deprecated spin_until_future_complete#704

Closed
hliberacki wants to merge 2 commits into
ros2:rollingfrom
hliberacki:hliberacki/spin_until
Closed

Replace deprecated spin_until_future_complete#704
hliberacki wants to merge 2 commits into
ros2:rollingfrom
hliberacki:hliberacki/spin_until

Conversation

@hliberacki

@hliberacki hliberacki commented Mar 31, 2022

Copy link
Copy Markdown

Replace deprecated spin_until_future_complete with spin_until_complete

Signed-off-by: Hubert Liberacki hliberacki@gmail.com

@hliberacki

hliberacki commented Mar 31, 2022

Copy link
Copy Markdown
Author

Due to RCLCPP API change ros2/rclcpp#1874.

audrow
audrow requested changes Mar 31, 2022
View reviewed changes

@audrow audrow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me, except I don't think that we should do the formatting changes as a part of this PR.

Perhaps another PR with the formatting changes is in order. Also, the code we have already passes our code style tests, so these changes may be unnecessary, unless we revise our coding styling standards, which would probably be a bigger discussion.

Comment thread ros2action/ros2action/verb/send_goal.py Outdated
fujitatomoya
fujitatomoya requested changes Apr 1, 2022
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after https://github.com/ros2/ros2cli/pull/704/files#r840064950 is addressed.

Comment thread ros2param/ros2param/api/__init__.py
Comment thread ros2topic/test/test_echo_pub.py
@hliberacki
Replace deprecated spin_until_future_complete with `spin_until_comp…
c80e8c8 
…lete`

Signed-off-by: Hubert Liberacki <hliberacki@gmail.com>
@hliberacki hliberacki force-pushed the hliberacki/spin_until branch from 00b4317 to c80e8c8 Compare April 2, 2022 22:07
@hliberacki

hliberacki commented Apr 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together.

fujitatomoya
fujitatomoya approved these changes Apr 11, 2022
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am good to go.

@fujitatomoya

fujitatomoya commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

@audrow requesting final review.

audrow
audrow approved these changes Jun 7, 2022
View reviewed changes

@audrow audrow left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI in a recent CI run.

@clalancette clalancette added the more-information-needed Further information is required label Jun 23, 2022
@clalancette clalancette mentioned this pull request Jun 24, 2022
Merged
@wjwwood

wjwwood commented Jun 24, 2022

Copy link
Copy Markdown
Member

Since this is part of rclpy changes, it's blocked on ros2/rclpy#919 (review), but is not needed to fix CI after ros2/rclcpp#1874 was merged prematurely.

@fujitatomoya fujitatomoya mentioned this pull request Jun 24, 2022
Closed
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:23
@fujitatomoya fujitatomoya mentioned this pull request Jan 23, 2023
Open
@christophebedard christophebedard mentioned this pull request Apr 2, 2024
Closed
@christophebedard

christophebedard commented Apr 2, 2024

Copy link
Copy Markdown
Member

I've opened #893 to replace this PR.

@christophebedard

christophebedard commented Apr 10, 2024

Copy link
Copy Markdown
Member

This can be closed, see #893 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@audrow audrow audrow approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

+1 more reviewer

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

more-information-needed Further information is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hliberacki @fujitatomoya @wjwwood @christophebedard @audrow @SteveMacenski @clalancette