refactor(exgentic_a2a_runner): vendor benchmark and agent env templates - #50
Merged
Merged
Conversation
The Getting Started and Benchmarks sections still implied users needed to build the agent + MCP images locally, but deploy-agent.sh and deploy-benchmark.sh default to pulling from ghcr.io/exgentic. Reword to match the current script defaults so new users don't chase build.sh. Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
deploy-benchmark.sh and deploy-agent.sh fetched .env templates at deploy
time from a personal-fork feature branch
(yoavkatz/agent-examples @ feature/exgentic-mcp-server). If that branch
were renamed, force-pushed, or the fork deleted, every deploy would
break; and any upstream edit silently changed deployed workloads with
no diff visible in this repo.
Vendor the five upstream files into env/ (mirroring the upstream layout)
and read from disk. The parse-env API call is unchanged; only the
source of the raw text moves from HTTP to filesystem.
- env/mcp/exgentic_benchmarks/.env.{gsm8k,tau2,appworld}
- env/a2a/exgentic_agent/.env.{example,advanced}
- env/README.md documents provenance and edit-in-tree workflow
- .gitignore: drop redundant env/ and ENV/ ignores; venv/ and .venv
still cover Python virtualenvs
- docs/workflow-diagrams.md: replace GitHub raw node with vendored env/
node in both scripts sequence and component diagrams
Contents diffed byte-identical against upstream at vendoring time.
Signed-off-by: Kelly Abuelsaad <kaymar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-benchmark.shanddeploy-agent.shwere fetching.envtemplates at deploy time fromyoavkatz/agent-exampleson the transientfeature/exgentic-mcp-serverbranch. If that branch is renamed, force-pushed, or the fork disappears, every deploy breaks — and any upstream edit silently changes deployed workloads with no diff in this repo.exgentic_a2a_runner/env/(mirroring the upstream path layout) and replaces thecurlfetch with a local file read. Theparse-envAPI call is preserved unchanged; only the source of the raw text moves from HTTP to filesystem..env.gsm8k,.env.tau2,.env.appworld(benchmarks) and.env.example,.env.advanced(agents)..env.advancedand.env.appworldare not referenced by current scripts but are vendored for parity.docs/workflow-diagrams.mdsequence and component diagrams updated to show a vendoredenv/filesystem node instead of a GitHub-raw node..gitignore— removed redundantenv/andENV/virtualenv-convention ignores that were blocking the vendored directory.venv/and.venvstill cover Python virtualenvs.Test plan
bash -non both scripts — parse cleanly.grep -rn "raw.githubusercontent.com/yoavkatz|feature/exgentic-mcp-server" exgentic_a2a_runner/— no matches.grep -nE "GH as GitHub|GitHub raw" exgentic_a2a_runner/docs/workflow-diagrams.md— no matches.diffeach vendored file against upstream at vendoring time — all identical.git check-ignoreon the vendored files — none ignored after.gitignorecleanup../deploy-and-evaluate.sh --benchmark gsm8k --agent tool_calling) to confirm the parse-env pipeline still receives the expected content and the deployed pod comes up ready.Notes
env/**/*.env*in-tree and commit — which is the whole point of vendoring.authbridge/intent_prompt.txtstill allowsraw.githubusercontent.comfor the deployed agents own runtime traffic (e.g. litellms model-pricing JSON). That is unrelated to the deploy-time fetch removed here.