Skip to content

Deprecate unused REXML::Text.read_with_substitution - #363

Merged
naitoh merged 1 commit into
ruby:masterfrom
kou:deprecate-text-read-with-substitution
Aug 31, 2026
Merged

Deprecate unused REXML::Text.read_with_substitution#363
naitoh merged 1 commit into
ruby:masterfrom
kou:deprecate-text-read-with-substitution

Conversation

@kou

@kou kou commented Aug 25, 2026

Copy link
Copy Markdown
Member

We don't want to maintain unused code.

Use REXML::Text.unnormalize instead.

@kou
Deprecate unused REXML::Text.read_with_substitution
f5cc986 
We don't want to maintain unused code.

Use `REXML::Text.unnormalize` instead.
Copilot AI lite review requested due to automatic review settings August 25, 2026 01:58
Copilot AI reviewed Aug 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@naitoh
naitoh merged commit 6a00268 into ruby:master Aug 31, 2026
71 checks passed
@naitoh

naitoh commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@kou
kou deleted the deprecate-text-read-with-substitution branch August 31, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@naitoh naitoh naitoh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kou @naitoh