Skip to content

chore: drop autoMergeAllowed from GitHub config policy #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ineedjet merged 1 commit into from
Sep 2, 2026
Merged

chore: drop autoMergeAllowed from GitHub config policy #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/github.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
config:
hasWikiEnabled: false
autoMergeAllowed: true
deleteBranchOnMerge: true
mergeCommitAllowed: false
rebaseMergeAllowed: false
Expand Down
11 changes: 5 additions & 6 deletions test/test_github_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class GitHubConfigTest(unittest.TestCase):
def setUp(self):
self.checks = {
"hasWikiEnabled": False,
"autoMergeAllowed": True,
"deleteBranchOnMerge": True,
}

def test_loads_repository_config(self):
Expand All @@ -28,7 +28,6 @@ def test_loads_repository_config(self):
set(checks),
{
"hasWikiEnabled",
"autoMergeAllowed",
"deleteBranchOnMerge",
"mergeCommitAllowed",
"rebaseMergeAllowed",
Expand Down Expand Up @@ -109,12 +108,12 @@ def test_evaluates_checks_and_reuses_api_response(self):

def request(repository, fields):
requests.append((repository, fields))
return {"hasWikiEnabled": False, "autoMergeAllowed": True}
return {"hasWikiEnabled": False, "deleteBranchOnMerge": True}

results = CHECK_GITHUB_CONFIG.evaluate_checks(self.checks, "owner/repo", request=request)

self.assertEqual([result.status for result in results], ["passed", "passed"])
self.assertEqual(requests, [("owner/repo", ["hasWikiEnabled", "autoMergeAllowed"])])
self.assertEqual(requests, [("owner/repo", ["hasWikiEnabled", "deleteBranchOnMerge"])])

def test_skips_check_without_requesting_it(self):
results = CHECK_GITHUB_CONFIG.evaluate_checks(
Expand All @@ -130,12 +129,12 @@ def test_aggregates_mismatches(self):
results = CHECK_GITHUB_CONFIG.evaluate_checks(
self.checks,
"owner/repo",
request=lambda _repository, _fields: {"hasWikiEnabled": True, "autoMergeAllowed": False},
request=lambda _repository, _fields: {"hasWikiEnabled": True, "deleteBranchOnMerge": False},
)

self.assertEqual(
[result.name for result in results if result.status == "failed"],
["hasWikiEnabled", "autoMergeAllowed"],
["hasWikiEnabled", "deleteBranchOnMerge"],
)

def test_reports_api_failure_for_each_dependent_check(self):
Expand Down