chore: drop Watchtower entirely - #122
Merged
Merged
Conversation
Redundant now that every deploy already runs docker compose pull && up -d for every app in a target's apps mapping (idempotent since #115) - a separate polling container added nothing except another thing needing Docker socket access on every host, and its label-based skip logic meant traefik would never actually get started by the automated path on a target that doesn't also run watchtower itself (the hawkeye gap flagged in #106). Removes the label from traefik/semaphore, deletes apps/watchtower/, and simplifies deploy.py: no more run_apps/all_apps split, every app in a target's apps mapping gets docker compose pull/up uniformly. Closes #118.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker compose pull && up -dfor every app in a target'sappsmapping (idempotent since feat: push-based deploy - target host needs only Docker + Compose #115) — a separate polling container added nothing except another thing needing Docker socket access on every host.traefik's Watchtower label + the label-based skip indeploy/deploy.pymeant it would never actually getdocker compose uprun for it by the automated path on a target that doesn't also runwatchtoweritself — which hawkeye doesn't (flagged in Normalize the hawkeye/rybbit deploy: configure prerequisites and get the first real deployment running #106).com.centurylinklabs.watchtower.enable=truefromapps/traefik/docker-compose.ymlandapps/semaphore/docker-compose.yml, deletesapps/watchtower/entirely.deploy/deploy.py: no morerun_apps/all_appssplit — every app in a target'sappsmapping getsdocker compose pull && docker compose up -d --remove-orphansuniformly, no label-based special-casing.RETIRED.md(modeled ondupmachine/flightdeck-config/RETIRED.md) to track apps dropped from the catalog going forward, starting with this one.Closes #118.
Test plan
deploy/unit tests (48, down from 50 — removed the two Watchtower-specific cases,DeployToHostTestnow asserts every app gets the compose command)load-yaml-matrix.pyagainsttargets/hawkeye.yml— unaffected, confirms no lingering reference to the removed apppre-commit run --all-filesclean