fix: resolve build-apps-bundle's local action ref for external callers - #165
Merged
Conversation
#164) ./.github/actions/build-bundle resolves against the calling repo's own checkout, not flightdeck's - broke every external caller (confirmed live on dupmachine/flightdeck: publish-apps-bundle failed instantly, and the deploy job gated on it got skipped, so a real release shipped zero apps). Use the same $/ self-repository-relative convention already used throughout this repo's own workflows instead of a hardcoded version tag, so it doesn't need bumping every release.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #164.
.github/actions/build-apps-bundle/action.ymlreferenced its sibling action asuses: ./.github/actions/build-bundle— a path relative to the caller's own checkout, not flightdeck's. Confirmed live ondupmachine/flightdeck:publish-apps-bundlefailed instantly for every external caller, and a downstreamdeployjob gated on it got skipped entirely, so a real release shipped with zero apps deployed.Rather than hardcode
rubykatzen/flightdeck/.github/actions/build-bundle@v0.11.0(the issue's suggested fix, which would need a manual bump on every release), this uses the$/self-repository-relative reference already used throughout this repo's own workflows (release.yml,deploy.yml, etc.) for exactly this kind of local, caller-independent reference — one line, no version-pin drift to maintain.Test plan
.github/actions/*/action.ymlfiles, only.github/workflows/*.yml)dupmachine/flightdeck)