Skip to content

Runner service windows acd update#1813

Merged
fdevans merged 6 commits into
rundeck:4.0.xfrom
jgarces-pd:runner-service-windows-acd-update
Jun 3, 2026
Merged

Runner service windows acd update#1813
fdevans merged 6 commits into
rundeck:4.0.xfrom
jgarces-pd:runner-service-windows-acd-update

Conversation

@jgarces-pd
Copy link
Copy Markdown
Contributor

Update Apache Commons Daemon Installation, which includes important information like:

  1. Usage of amd64/prunsrv.exe on JDK/JRE 64 bits instead of the regular binary on the root folder
  2. New script that kills the runner service for better task/pid handling
  3. Increasing maximum memory by default to 4GB (Xmx); Minimum is still the same, at 1GB (Xms)
  4. Other tips and cosmetic fixes on the doc.

…ent, //IS//runner syntax, LogLevel=Info, Jvm=auto, PID-scoped stop-runner.bat via cmd.exe (replacing bare TASKKILL), runner.pid, and stop/conhost troubleshooting notes
…on before rename; architecture-mismatch error after rename, referencing runner.exe), remove the TASKKILL warning, and add the missing line-continuation caret to --JvmMs=1024
@jgarces-pd jgarces-pd requested a review from a team June 2, 2026 21:22
@jgarces-pd
Copy link
Copy Markdown
Contributor Author

@forrestrd @fdevans

@fdevans fdevans requested a review from Copilot June 3, 2026 18:10
@fdevans fdevans added this to the 5.20.1 milestone Jun 3, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Windows “Runner as a service” documentation to reflect newer Apache Commons Daemon (procrun) usage, including 64-bit binary selection, improved stop behavior via a PID-based stop script, and updated JVM defaults.

Changes:

  • Added guidance/warnings for using the correct 64-bit prunsrv.exe with 64-bit JDK/JREs.
  • Introduced a PID-based stop-runner.bat and updated the procrun install command (including higher default -Xmx).
  • Added additional notes/troubleshooting tips and updated example output.
Comments suppressed due to low confidence (1)

docs/learning/howto/runner-service-windows.md:178

  • The command sets --LogLevel=Info, but the sample output includes [debug] entries. Either set --LogLevel=Debug or update the example logs to match the Info level to avoid confusing readers.
[2023-10-04 13:12:51] [info]  ( prunsrv.c:2018) [ 5164] Apache Commons Daemon procrun (1.5.1.0 64-bit) started.
[2023-10-04 13:12:51] [debug] ( prunsrv.c:774 ) [ 5164] Installing service...
[2023-10-04 13:12:51] [info]  ( prunsrv.c:831 ) [ 5164] Installing service 'runner' name 'Runner'.
[2023-10-04 13:12:51] [debug] ( prunsrv.c:865 ) [ 5164] Setting service user 'LocalSystem'.
[2023-10-04 13:12:51] [info]  ( prunsrv.c:882 ) [ 5164] Service 'runner' installed.

Comment thread docs/learning/howto/runner-service-windows.md
Comment thread docs/learning/howto/runner-service-windows.md
Comment thread docs/learning/howto/runner-service-windows.md
Comment thread docs/learning/howto/runner-service-windows.md Outdated
Comment thread docs/learning/howto/runner-service-windows.md Outdated
Comment thread docs/learning/howto/runner-service-windows.md Outdated
Copy link
Copy Markdown
Contributor

@fdevans fdevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets' address the CoPilot feedback then I can approve and merge

jgarces-pd and others added 3 commits June 3, 2026 14:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@jgarces-pd jgarces-pd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the suggestions are not true, except using "bat" as markdown code block language

Comment thread docs/learning/howto/runner-service-windows.md
Comment thread docs/learning/howto/runner-service-windows.md
Comment thread docs/learning/howto/runner-service-windows.md Outdated
Comment thread docs/learning/howto/runner-service-windows.md Outdated
Comment thread docs/learning/howto/runner-service-windows.md
@fdevans fdevans merged commit 7f06762 into rundeck:4.0.x Jun 3, 2026
1 of 2 checks passed
@jgarces-pd jgarces-pd deleted the runner-service-windows-acd-update branch June 3, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants