fix(interrupt): correct malformed FIS role trust policy#23
Open
frank-bee wants to merge 1 commit into
Open
Conversation
The aws-fis-itn trust policy nested the service principal as [["fis.amazonaws.com"]], which IAM rejects on CreateRole with MalformedPolicyDocument (Syntax error at position (8,9)). This made 'roc interrupt' fail whenever the role did not already exist. Flatten Principal.Service to a plain string and add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roc interruptfails whenever theaws-fis-itnFIS role doesn't already exist. The trust policy literal nests the service principal as a sub-array:IAM rejects this on
CreateRole:(Position
(8,9)is exactly the inner[.) All pre-flight checks pass — it only fails at role creation — so the command is unusable on first run in any account.Reported in #22.
Fix
Flatten
Principal.Serviceto a plain string:Added
TestTrustPolicyIsValidForIAMto guard against the nested-array regression (assertsPrincipal.Servicedecodes as a string or flat[]string).Testing
go build ./...— OKgo test ./internal/cli/ -run TestTrustPolicyIsValidForIAM— PASSroc interruptcreates the role and runs the FIS spot-interruption experiment successfully.