-
Notifications
You must be signed in to change notification settings - Fork 240
Add retain_back (aka truncate_front) method to Deque #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nullstalgia
wants to merge
7
commits into
rust-embedded:main
Choose a base branch
from
nullstalgia:deque_retain_back
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+322
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4ba7ecb
Add retain_back method to Deque
nullstalgia c326acc
Update changelog for retain_front
nullstalgia 3084de4
Improve comments, limit scope of unsafe within Deque::retain_back
nullstalgia 661bd18
Fix cargo fmt being unhappy with changes to Deque::retain_back
nullstalgia b28508d
Remove println!'s from Deque::retain_back unit tests
nullstalgia 544b20f
Remove (now) unused variables from retain_back unit test
nullstalgia cc5cff1
Merge branch 'main' into deque_retain_back
nullstalgia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply:
tester .push_front(Droppable::new()) .expect("deque must have room for all {LEN} entries");There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.expect()does not support formatting strings as it is not a macro.Would you prefer that I use
.expect(format!()), or simply not mention theLENat all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, that's why I checked before commenting: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=f9cecd4084d473ebc5a41dab7b8b1c21
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be missing something, but your example isn't very clear/is conflicting.
It's
expect()-ing theOk(())variant (so no error message gets printed due to a failed unwrap), and the#![allow(unused)]hides the warning thatLENis never read.https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=06510eeb3a4c30ff16264f72f5f914f2