Bring fix for fully qualified path#238
Merged
Merged
Conversation
When a downstream crate has a [minimal-version check], the version of derive_arbitrary that gets pulled in is 1.4.0, which does not carry the fix the fully qualified path on result that was made in de2becf This bumps the patch version of the derive from arbitrary so that a downstream crate does not have to make a direct dependency expression against `derive_arbitrary`. minimal-version checks are useful for checking API stability. [minimal-version check]: <https://github.com/RustCrypto/actions/blob/master/.github/workflows/minimal-versions.yml>
Member
|
Generally I don't think it actually makes sense to do things like this: the version dep is "the latest version dep you need" which makes it maximally flexible for people. When you use That said, that fix is years old now, so I don't particularly mind merging this. I don't plan to cut a release for this crate soon though (some other maintainer might). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a downstream crate has a minimal-version check, the version of derive_arbitrary that gets pulled in is 1.4.0, which does not carry the fix the fully qualified path on result that was made in de2becf
This bumps the patch version of the derive from arbitrary so that a downstream crate does not have to make a direct dependency expression against
derive_arbitrary.minimal-version checks are useful for checking API stability.