Skip to content

Add try job=... alias for try jobs=...#495

Merged
Kobzol merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:job-alias
Dec 15, 2025
Merged

Add try job=... alias for try jobs=...#495
Kobzol merged 1 commit into
rust-lang:mainfrom
JonathanBrouwer:job-alias

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

I've seen this done wrong quite a lot (such as in rust-lang/rust#149354), so lets fix it :)
I'm also guilty of this mistake myself...

I'm not familiar with this codebase but seems like an easy change?

@fmease

fmease commented Dec 15, 2025

Copy link
Copy Markdown
Member

Could you also update the help text that's emitted by the help command? Thanks!

@Kobzol

Kobzol commented Dec 15, 2025

Copy link
Copy Markdown
Member

I was thinking that we could improve the message by doing a nearest string search and provide something "did you mean jobs?". But in yna case, that is a separate thing, this alias makes sense.

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@fmease Done!
I improvised the style a bit for the help message, think this should be clear

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Kobzol Kobzol added this pull request to the merge queue Dec 15, 2025
Merged via the queue into rust-lang:main with commit 51347e5 Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants