[Result migration] Don't return options for StringArray iterators#1266
Merged
Conversation
Instead, treat a `None` as indicative of a bug in the code, and panic with a clear message that something went wrong. Also update the documentation of `StringArray::iter()` to reflect the correct iterated type. Fixes rust-lang#1263
ehuss
added
the
semver-breaking-change
ehuss
approved these changes
Jun 12, 2026
Contributor
There was a problem hiding this comment.
Thanks! I appreciate it!
I was going to wait on semver breaking changes, but since #1274 was merged I suppose we can go ahead and cycle another version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, treat a
Noneas indicative of a bug in the code, and panic with a clear message that something went wrong.Also update the documentation of
StringArray::iter()to reflect the correct iterated type.Fixes #1263