rustdoc: use ThinVec for cleaned generics by notriddle · Pull Request #102928 · rust-lang/rust

notriddle · 2022-10-11T17:13:32Z

rustbot · 2022-10-11T17:13:35Z

Some changes occurred in src/librustdoc/clean/types.rs

rust-highfive · 2022-10-11T17:13:35Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon.

Please see the contribution instructions for more information.

notriddle · 2022-10-11T18:01:12Z

@bors try @rust-timer queue

rust-timer · 2022-10-11T18:01:14Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-10-11T18:01:23Z

⌛ Trying commit 5b312b169d8148e6f52067f1bf28d8fea611ae18 with merge 234a079207af4dc967931c934e36a0c65cdaab6e...

bors · 2022-10-11T20:41:44Z

☀️ Try build successful - checks-actions
Build commit: 234a079207af4dc967931c934e36a0c65cdaab6e (234a079207af4dc967931c934e36a0c65cdaab6e)

rust-timer · 2022-10-11T20:41:46Z

Queued 234a079207af4dc967931c934e36a0c65cdaab6e with parent cde693c, future comparison URL.

rust-timer · 2022-10-11T22:47:22Z

Finished benchmarking commit (234a079207af4dc967931c934e36a0c65cdaab6e): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.7%	[3.7%, 3.7%]	1
Improvements ✅ (primary)	-1.3%	[-1.6%, -1.2%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.3%	[-1.6%, -1.2%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.0%, 4.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

notriddle · 2022-10-11T23:21:55Z

As expected, the three max-RSS improvements are to doc tests, while the one max-RSS regression is an opt test (so it's probably spurious).

notriddle · 2022-10-12T18:30:49Z

@bors try @rust-timer queue

rust-timer · 2022-10-12T18:30:51Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-10-12T18:30:58Z

⌛ Trying commit 1265a4d7660f55c54849a04edef25e3523a8866f with merge 5a731b66e857fa59cdf13badedcf079f0b34e8be...

nnethercote · 2022-10-12T20:39:55Z

Which types are shrunk by this change? We have a practice of using static assertions to check the size of often-instantiated types, e.g. here. It might be useful to do likewise here.

bors · 2022-10-12T20:47:10Z

☀️ Try build successful - checks-actions
Build commit: 5a731b66e857fa59cdf13badedcf079f0b34e8be (5a731b66e857fa59cdf13badedcf079f0b34e8be)

rust-timer · 2022-10-12T20:47:13Z

Queued 5a731b66e857fa59cdf13badedcf079f0b34e8be with parent 538f118, future comparison URL.

notriddle · 2022-10-12T21:29:50Z

@nnethercote rustdoc::clean::types::Generics, which is included as as member of Function, Trait, TraitAlias, Struct, Union, Enum, Typedef, OpaqueTy, Impl, and ItemKind::TyAssocTypeItem. It was 48 bytes before this PR, and 16 bytes afterward.

I've added a line to track this.

rust-timer · 2022-10-12T22:06:51Z

Finished benchmarking commit (5a731b66e857fa59cdf13badedcf079f0b34e8be): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.5%	[2.0%, 3.0%]	2
Regressions ❌ (secondary)	2.7%	[2.0%, 5.1%]	9
Improvements ✅ (primary)	-1.5%	[-1.8%, -1.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-1.8%, 3.0%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	2.8%	[2.8%, 2.8%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

GuillaumeGomez · 2022-11-03T10:00:42Z

Nice!

@bors r+ rollup=iffy

bors · 2022-11-03T10:00:44Z

📌 Commit eb29696 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2022-11-03T12:36:39Z

⌛ Testing commit eb29696 with merge 254797dfc7d500900b5cb4531b8f4f55d895e2c1...

fmease · 2022-11-03T13:02:30Z

                    tcx.generics_of(assoc_item.def_id),
                    ty::GenericPredicates { parent: None, predicates },
                );
-                // Move bounds that are (likely) directly attached to the associated type


Ah, you replaced the comment I updated with its older version ^^' No worries, I'm gonna revert that as part of a bigger PR in the future.

bors · 2022-11-03T16:51:40Z

💥 Test timed out

notriddle · 2022-11-03T17:25:30Z

Same error as

rustc_metadata: Encode even less doc comments #103496 (comment)

@bors retry

rust-log-analyzer · 2022-11-03T17:31:15Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-11-04T03:32:22Z

⌛ Testing commit eb29696 with merge 15d7556...

bors · 2022-11-04T07:02:49Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 15d7556 to master...

rust-timer · 2022-11-04T09:27:40Z

Finished benchmarking commit (15d7556): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.8%, -1.7%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.8%, -1.1%]	3
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-1.4%	[-1.8%, -1.1%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

rust-highfive assigned CraftSpider Oct 11, 2022

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2022

notriddle marked this pull request as draft October 11, 2022 17:13

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 11, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 11, 2022

rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Oct 12, 2022

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 12, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 12, 2022

This comment has been minimized.

Sign in to view

notriddle marked this pull request as ready for review November 2, 2022 23:17

notriddle added 3 commits November 2, 2022 16:17

rustdoc: use ThinVec for cleaned generics

03968a8

rustdoc: remove unneeded Box from ItemKind

24714b8

rustdoc: add size tracking for Generics

eb29696

notriddle assigned GuillaumeGomez and unassigned CraftSpider Nov 2, 2022

notriddle requested a review from GuillaumeGomez November 2, 2022 23:19

GuillaumeGomez approved these changes Nov 3, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022

fmease reviewed Nov 3, 2022

View reviewed changes

fmease mentioned this pull request Nov 3, 2022

rustbot thinks users with private activity are new contributors rust-lang/triagebot#1670

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 3, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2022

bors merged commit 15d7556 into rust-lang:master Nov 4, 2022

rustbot added this to the 1.67.0 milestone Nov 4, 2022

notriddle deleted the notriddle/rustdoc-thin-vec branch November 4, 2022 07:03

Uh oh!

Conversation

notriddle commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 11, 2022

Uh oh!

rust-highfive commented Oct 11, 2022

Uh oh!

notriddle commented Oct 11, 2022

Uh oh!

rust-timer commented Oct 11, 2022

Uh oh!

bors commented Oct 11, 2022

Uh oh!

bors commented Oct 11, 2022

Uh oh!

rust-timer commented Oct 11, 2022

Uh oh!

rust-timer commented Oct 11, 2022

Overall result: ✅ improvements - no action needed

Footnotes

Uh oh!

notriddle commented Oct 11, 2022

Uh oh!

This comment has been minimized.

notriddle commented Oct 12, 2022

Uh oh!

rust-timer commented Oct 12, 2022

Uh oh!

bors commented Oct 12, 2022

Uh oh!

nnethercote commented Oct 12, 2022

Uh oh!

bors commented Oct 12, 2022

Uh oh!

rust-timer commented Oct 12, 2022

Uh oh!

notriddle commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-timer commented Oct 12, 2022

Overall result: ✅ improvements - no action needed

Footnotes

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Nov 3, 2022

Uh oh!

bors commented Nov 3, 2022

Uh oh!

bors commented Nov 3, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Nov 3, 2022

Uh oh!

notriddle commented Nov 3, 2022

Uh oh!

rust-log-analyzer commented Nov 3, 2022

Uh oh!

bors commented Nov 4, 2022

Uh oh!

bors commented Nov 4, 2022

Uh oh!

rust-timer commented Nov 4, 2022

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

notriddle commented Oct 11, 2022 •

edited

Loading

notriddle commented Oct 12, 2022 •

edited

Loading