Skip to content

Support the remaining openwrt targets#106265

Closed
lu-zero wants to merge 1 commit into
rust-lang:masterfrom
lu-zero:openwrt-targets
Closed

Support the remaining openwrt targets#106265
lu-zero wants to merge 1 commit into
rust-lang:masterfrom
lu-zero:openwrt-targets

Conversation

@lu-zero

@lu-zero lu-zero commented Dec 29, 2022

Copy link
Copy Markdown
Contributor

They are the same as the unknown-linux ones.

I'm currently maintaining this patch trying to have rust included in OpenWRT and ended up adding the alias support to the targets to keep the patch small enough.

Is it acceptable to add aliases this way?

@rustbot

rustbot commented Dec 29, 2022

Copy link
Copy Markdown
Collaborator

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2022
@rustbot

rustbot commented Dec 29, 2022

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@Noratrieb

Copy link
Copy Markdown
Member

r? wesleywiser

@rustbot rustbot assigned wesleywiser and unassigned Noratrieb Dec 29, 2022
@rust-log-analyzer

This comment has been minimized.

@bors

bors commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #105712) made this pull request unmergeable. Please resolve the merge conflicts.

They are the same as the unknown-linux ones.
@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #106656) made this pull request unmergeable. Please resolve the merge conflicts.

@lu-zero

lu-zero commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

I decided to remap the targets in openwrt/packages#19863 once a stable release is compatible with their pick of host ssl hopefully no changes in rustc will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants