bootstrap: cleanup the list of extra check cfgs by Urgau · Pull Request #107080 · rust-lang/rust

Urgau · 2023-01-19T17:09:25Z

This PR performs some cleanups on the EXTRA_CHECK_CFGS list in bootstrap.

target_os=watchos: no longer relevant because there are now proper targets *-apple-watchos
target_arch=nvptx64: target nvptx64-nvidia-cuda makes it useless
target_arch=le32: target was removed (Remove support for the PNaCl target (le32-unknown-nacl) #45041)
release: was removed from rustfmt (Remove useless conditional compilation rustfmt#5375 and Remove useless conditional compilation - 2 rustfmt#5449)
dont_compile_me: was removed from stdarch (Remove useless conditional compilation stdarch#1308)

Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

rustbot · 2023-01-19T17:09:32Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-01-19T17:09:36Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rustbot · 2023-01-19T17:34:40Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Mark-Simulacrum · 2023-01-21T18:02:34Z

@bors r+ rollup=iffy

bors · 2023-01-21T18:02:36Z

📌 Commit cc00a21 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - ~~`release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449 (despite the changes being done more than 6 months ago there hasn't been any rustfmt subtree sync) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

matthiaskrgr · 2023-01-22T10:42:04Z

@bors r- failed in a rollup
https://github.com/rust-lang-ci/rust/actions/runs/3979179804/jobs/6821444168#step:26:8323
#107183

Urgau · 2023-01-22T18:13:01Z

Forgot to remove a target_arch="le32" in fuschia and l4re. I've verified with rg "\"le32\"" that no other le32 are found in the repository. Should be ready to go.

@rustbot ready

See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

- `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: `nvptx64-nvidia-cuda` - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

Urgau · 2023-01-25T14:22:44Z

A rustfmt subtree sync has been done (#107275), so I've re-removed the release cfg.

Mark-Simulacrum · 2023-01-29T18:01:38Z

@bors r+

bors · 2023-01-29T18:01:39Z

📌 Commit a01a540 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…k-cfgs, r=Mark-Simulacrum bootstrap: cleanup the list of extra check cfgs This PR performs some cleanups on the `EXTRA_CHECK_CFGS` list in bootstrap. - `target_os=watchos`: no longer relevant because there are now proper targets `*-apple-watchos` - `target_arch=nvptx64`: target `nvptx64-nvidia-cuda` makes it useless - `target_arch=le32`: target was removed (rust-lang#45041) - `release`: was removed from rustfmt (rust-lang/rustfmt#5375 and rust-lang/rustfmt#5449) - `dont_compile_me`: was removed from stdarch (rust-lang/stdarch#1308) Also made some external cfg exception mode clear and only activated for rustc and rustc tools (as to not have the Standard Library unintentionally depend on them).

bors · 2023-01-30T01:26:00Z

⌛ Testing commit a01a540 with merge b06d5b404ea8f980afe1387f0e0ba85d0bd20aaf...

bors · 2023-01-30T05:41:00Z

💥 Test timed out

rust-log-analyzer · 2023-01-30T06:17:35Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Urgau · 2023-01-30T08:20:45Z

Seems like the checkout of the src/doc/edition-guide submodule never happened in more than 4h, leading to the timeout. This failure is completely unrelated to this PR, should be retried.

albertlarsan68 · 2023-01-30T08:29:06Z

@bors retry (supurious timeout downloading submodules)

bors · 2023-01-30T13:56:43Z

⌛ Testing commit a01a540 with merge 006ca9b...

bors · 2023-01-30T16:46:10Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 006ca9b to master...

rust-timer · 2023-01-30T18:14:22Z

Finished benchmarking commit (006ca9b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.7%	[4.7%, 4.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[-2.3%, 4.7%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

rustbot assigned Mark-Simulacrum Jan 19, 2023

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 19, 2023

This comment has been minimized.

Sign in to view

Urgau force-pushed the cleanup-bootstrap-extra-check-cfgs branch from d94ee45 to cc00a21 Compare January 19, 2023 17:34

Urgau mentioned this pull request Jan 19, 2023

Remove obsolete cfg for nvptx rust-lang/stdarch#1372

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023

compiler-errors mentioned this pull request Jan 22, 2023

Rollup of 7 pull requests #107183

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2023

Urgau force-pushed the cleanup-bootstrap-extra-check-cfgs branch 2 times, most recently from ae17e41 to e6e3db9 Compare January 22, 2023 17:34

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2023

Urgau added 2 commits January 25, 2023 15:07

Remove outdated cfg on le32

dde74fe

See rust-lang#45041 for the removal of the target (le32-unknown-nacl).

Urgau force-pushed the cleanup-bootstrap-extra-check-cfgs branch from e6e3db9 to a01a540 Compare January 25, 2023 14:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023

compiler-errors mentioned this pull request Jan 29, 2023

Rollup of 5 pull requests #107456

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2023

bors merged commit 006ca9b into rust-lang:master Jan 30, 2023

rustbot added this to the 1.69.0 milestone Jan 30, 2023

bors mentioned this pull request Jan 30, 2023

migrate compiler, bootstrap and compiletest to windows-rs #106610

Merged

Urgau deleted the cleanup-bootstrap-extra-check-cfgs branch May 5, 2023 16:44

Uh oh!

Conversation

Urgau commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 19, 2023

Uh oh!

rustbot commented Jan 19, 2023

Uh oh!

This comment has been minimized.

rustbot commented Jan 19, 2023

Uh oh!

Mark-Simulacrum commented Jan 21, 2023

Uh oh!

bors commented Jan 21, 2023

Uh oh!

matthiaskrgr commented Jan 22, 2023

Uh oh!

Urgau commented Jan 22, 2023

Uh oh!

Urgau commented Jan 25, 2023

Uh oh!

Mark-Simulacrum commented Jan 29, 2023

Uh oh!

bors commented Jan 29, 2023

Uh oh!

bors commented Jan 30, 2023

Uh oh!

bors commented Jan 30, 2023

Uh oh!

rust-log-analyzer commented Jan 30, 2023

Uh oh!

Urgau commented Jan 30, 2023

Uh oh!

albertlarsan68 commented Jan 30, 2023

Uh oh!

bors commented Jan 30, 2023

Uh oh!

bors commented Jan 30, 2023

Uh oh!

rust-timer commented Jan 30, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Urgau commented Jan 19, 2023 •

edited

Loading