Skip to content

stdarch: update submodule#110285

Merged
bors merged 6 commits into
rust-lang:masterfrom
KisaragiEffective:sync-stdarch
May 9, 2023
Merged

stdarch: update submodule#110285
bors merged 6 commits into
rust-lang:masterfrom
KisaragiEffective:sync-stdarch

Conversation

@KisaragiEffective

@KisaragiEffective KisaragiEffective commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

We need this commit introduced by stdarch#1411 in order to merge #110189.

Note to myself: git pull && git submodule update --remote library/stdarch

@rustbot

rustbot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot

rustbot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 13, 2023
@rustbot

rustbot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@JohnTitor

Copy link
Copy Markdown
Member

r? @Amanieu

@rustbot rustbot assigned Amanieu and unassigned joshtriplett Apr 14, 2023
@Amanieu

Amanieu commented Apr 15, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit d5357c1 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2023
@bors

bors commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d5357c1 with merge 727db2d74e04267f48bbe758ac55ac05168bf4c3...

@bors

bors commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2023
@rust-log-analyzer

This comment has been minimized.

@KisaragiEffective

Copy link
Copy Markdown
Contributor Author

@bors retry

@bors

bors commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

@KisaragiEffective: 🔑 Insufficient privileges: not in try users

@Amanieu

Amanieu commented Apr 21, 2023

Copy link
Copy Markdown
Member

cc @lu-zero I think this failure may be due to your powerpc changes.

@Amanieu

Amanieu commented Apr 23, 2023

Copy link
Copy Markdown
Member

This should be fixed by rust-lang/stdarch#1420.

@lu-zero

lu-zero commented Apr 23, 2023

Copy link
Copy Markdown
Contributor

Somehow the notification did not hit my mailbox properly, sorry for the noise.

@Amanieu

Amanieu commented Apr 23, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 49413bb has been approved by Amanieu

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2023
@bors

bors commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 1042b65 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 24, 2023
@bors

bors commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1042b65 with merge faca88b6c23897bb1e9053125de3518858ed3837...

@rust-log-analyzer

This comment has been minimized.

@bors

bors commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 25, 2023
@taiki-e

taiki-e commented Apr 25, 2023

Copy link
Copy Markdown
Member

The above test failure is related to rust-lang/stdarch#1407.

Removing the following line should fix it.

println!("crypto: {}", is_arm_feature_detected!("crypto"));

@Urgau Urgau mentioned this pull request May 5, 2023
@Amanieu

Amanieu commented May 6, 2023

Copy link
Copy Markdown
Member

You need to apply the change in #110285 (comment) to your PR otherwise the tests will not pass.

@KisaragiEffective

Copy link
Copy Markdown
Contributor Author

It should be updated properly.

@Amanieu

Amanieu commented May 8, 2023

Copy link
Copy Markdown
Member

No, you need to delete this line on the rust-lang/rust side: https://github.com/rust-lang/rust/blob/master/library/std/tests/run-time-detect.rs#L19

@KisaragiEffective

Copy link
Copy Markdown
Contributor Author

Oh, okay...

@Amanieu

Amanieu commented May 8, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 8, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit a4014f0 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023
@bors

bors commented May 9, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a4014f0 with merge f7b831a...

@bors

bors commented May 9, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing f7b831a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2023
@bors bors merged commit f7b831a into rust-lang:master May 9, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 9, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f7b831a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.6% [2.0%, 3.0%] 3
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 659.045s -> 658.646s (-0.06%)

thomcc pushed a commit to pgcentralfoundation/postgrestd that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.