Suggest ref mut for pattern matching assignment by chenyukang · Pull Request #119650 · rust-lang/rust

chenyukang · 2024-01-06T05:23:16Z

rustbot · 2024-01-06T05:23:23Z

(rustbot has picked a reviewer for you, use r? to override)

petrochenkov · 2024-01-06T11:29:28Z

r? compiler
I'm overloaded with reviews.

wesleywiser · 2024-01-26T19:58:04Z

+        matches!(
+            self.local_info(),
+            LocalInfo::User(BindingForm::Var(VarBindingForm {
+                binding_mode: ty::BindingMode::BindByValue(Mutability::Not),


This seems more restrictive than the method name would imply. Can we check the mutability in the caller instead to make this more generic like the name?

yeah, it's not a general api.
I found the caller already has decl.can_be_made_mutable() to make it safe to add mut, so we don't need to check it.

bors · 2024-02-09T18:48:04Z

☔ The latest upstream changes (presumably #120843) made this pull request unmergeable. Please resolve the merge conflicts.

chenyukang · 2024-02-11T02:37:06Z

@rustbot ready

… r=compiler-errors Remove a bunch of dead parameters in functions Found this kind of issue when working on rust-lang#119650 I wrote a trivial toy lint and manual review to find these.

Rollup merge of rust-lang#120917 - chenyukang:yukang-dead-parameters, r=compiler-errors Remove a bunch of dead parameters in functions Found this kind of issue when working on rust-lang#119650 I wrote a trivial toy lint and manual review to find these.

wesleywiser · 2024-03-21T18:32:01Z

Thanks @chenyukang!

@bors r+

…er-errors Remove a bunch of dead parameters in functions Found this kind of issue when working on rust-lang/rust#119650 I wrote a trivial toy lint and manual review to find these.

fmease · 2024-04-24T03:11:59Z

Oh no, bors never caught the r+ :(

@bors r=wesleywiser

bors · 2024-04-24T03:12:02Z

📌 Commit 5b26c10 has been approved by wesleywiser

It is now in the queue for this repository.

fmease · 2024-04-24T03:13:05Z

More than a month has passed, this might no longer build and might require a rebase. Therefore:

@bors rollup=iffy

bors · 2024-04-24T06:02:14Z

⌛ Testing commit 5b26c10 with merge 8e84124...

…, r=wesleywiser Suggest ref mut for pattern matching assignment Fixes rust-lang#118596

bors · 2024-04-24T06:11:09Z

💔 Test failed - checks-actions

fmease · 2024-04-24T11:31:06Z

@chenyukang Could you rebase and fix CI? Thanks!
@rustbot author

matthiaskrgr · 2024-04-24T17:06:12Z

@bors r-

chenyukang · 2024-04-24T21:28:46Z

@chenyukang Could you rebase and fix CI? Thanks! @rustbot author

rebased and resolved tidy issues.

fmease · 2024-04-25T06:41:02Z

@bors r=wesleywiser rollup

bors · 2024-04-25T06:41:05Z

📌 Commit be9dbe9 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2024-04-25T08:52:22Z

⌛ Testing commit be9dbe9 with merge 31e6e8c...

bors · 2024-04-25T10:58:06Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 31e6e8c to master...

rust-timer · 2024-04-25T12:55:11Z

Finished benchmarking commit (31e6e8c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.6%	[1.1%, 2.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.011s -> 673.3s (0.49%)
Artifact size: 315.97 MiB -> 315.96 MiB (-0.00%)

…er-errors Remove a bunch of dead parameters in functions Found this kind of issue when working on rust-lang/rust#119650 I wrote a trivial toy lint and manual review to find these.

rustbot assigned petrochenkov Jan 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 6, 2024

rustbot assigned wesleywiser and unassigned petrochenkov Jan 6, 2024

wesleywiser reviewed Jan 26, 2024

View reviewed changes

chenyukang force-pushed the yukang-fix-118596-ref-mut branch 3 times, most recently from 7a9b4fb to 5b26c10 Compare February 11, 2024 02:31

chenyukang mentioned this pull request Feb 11, 2024

Remove a bunch of dead parameters in functions #120917

Merged

wesleywiser approved these changes Mar 21, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024

This comment was marked as resolved.

Sign in to view

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024

Auto merge of rust-lang#119650 - chenyukang:yukang-fix-118596-ref-mut…

8e84124

…, r=wesleywiser Suggest ref mut for pattern matching assignment Fixes rust-lang#118596

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2024

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024

Suggest ref mut for pattern matching assignment

be9dbe9

chenyukang force-pushed the yukang-fix-118596-ref-mut branch from 5b26c10 to be9dbe9 Compare April 24, 2024 20:56

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2024

bors merged commit 31e6e8c into rust-lang:master Apr 25, 2024

rustbot added this to the 1.79.0 milestone Apr 25, 2024

Uh oh!

Conversation

chenyukang commented Jan 6, 2024

Uh oh!

rustbot commented Jan 6, 2024

Uh oh!

petrochenkov commented Jan 6, 2024

Uh oh!

Uh oh!

wesleywiser Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

chenyukang Feb 11, 2024

Choose a reason for hiding this comment

Uh oh!

bors commented Feb 9, 2024

Uh oh!

chenyukang commented Feb 11, 2024

Uh oh!

wesleywiser commented Mar 21, 2024

Uh oh!

fmease commented Apr 24, 2024

Uh oh!

bors commented Apr 24, 2024

Uh oh!

fmease commented Apr 24, 2024

Uh oh!

This comment was marked as resolved.

bors commented Apr 24, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 24, 2024

Uh oh!

fmease commented Apr 24, 2024

Uh oh!

matthiaskrgr commented Apr 24, 2024

Uh oh!

chenyukang commented Apr 24, 2024

Uh oh!

fmease commented Apr 25, 2024

Uh oh!

bors commented Apr 25, 2024

Uh oh!

bors commented Apr 25, 2024

Uh oh!

bors commented Apr 25, 2024

Uh oh!

rust-timer commented Apr 25, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants