Use ensure when the result of the query is not needed beyond its Resultness

[oli-obk]

while I would like to just remove the tcx methods for ensure-only queries, that is hard to do without another query annotation or by turning the define_callbacks macro into a proc macro to get more control

should fix perf regression of #120558

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or
reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit aa6f45e with merge 07e49d4...

[bors]

☀️ Try build successful - checks-actions
Build commit: 07e49d4 (07e49d48504ebcd5c84528313a1730dc7cbc7502)

[rust-timer]

Finished benchmarking commit (07e49d4): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	3
Improvements ✅ (secondary)	-0.4%	[-0.6%, -0.3%]	14
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.0%, 4.2%]	2
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[2.0%, 4.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.662s -> 664.652s (0.30%)
Artifact size: 308.26 MiB -> 308.24 MiB (-0.01%)

[oli-obk]

@bors r=davidtwco

doesn't fix the regression, but is an improvement on its own.

[bors]

📌 Commit aa6f45e has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit aa6f45e with merge 232919c...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 232919c to master...

[rust-timer]

Finished benchmarking commit (232919c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.007s -> 666.159s (0.02%)
Artifact size: 308.04 MiB -> 308.05 MiB (0.01%)