Relax framework linking test#123410
Merged
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
madsmtm
referenced
this pull request
Apr 3, 2024
Member
|
You can't just omit part of the stderr file. Compiletest tests that the stderr of rustc exactly matches the file. You will have to do normalization to replace part of the stderr with a fixed string. As an example of output normalization see rust/tests/ui/error-codes/E0523.rs Line 7 in 4c6c629 |
Contributor
Author
|
Yes you can, because of the |
Member
|
I didn't know that annotation existed. |
fmease
reviewed
Apr 5, 2024
fmease
added
S-waiting-on-author
This test was introduced in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`.
madsmtm
force-pushed
the
relax-framework-linking-test
branch
from
dfd40be to
de21296
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123410 (Relax framework linking test) - rust-lang#123446 (Fix incorrect 'llvm_target' value used on watchOS target) - rust-lang#123579 (add some more tests) - rust-lang#123581 (Add `f16` and `f128` to rustdoc's `PrimitiveType`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 7, 2024
Rollup merge of rust-lang#123410 - madsmtm:relax-framework-linking-test, r=fmease Relax framework linking test This test was introduced by myself in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`, which [causes a test failure for Chromium](https://issues.chromium.org/issues/332562251).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was introduced by myself in #118644, but was over-specified in that it assumed the path of the linker was always
cc, which causes a test failure for Chromium.