Skip to content

coverage: Disable the zombie MC/DC tests until they support LLVM 19#131388

Closed
Zalathar wants to merge 1 commit into
rust-lang:masterfrom
Zalathar:zombie-mcdc
Closed

coverage: Disable the zombie MC/DC tests until they support LLVM 19#131388
Zalathar wants to merge 1 commit into
rust-lang:masterfrom
Zalathar:zombie-mcdc

Conversation

@Zalathar

@Zalathar Zalathar commented Oct 8, 2024

Copy link
Copy Markdown
Member

Currently these tests only run against LLVM 18, but the default is now LLVM 19, which makes them very tricky to bless. Since #126733 is going to drop support for MC/DC in LLVM 18 anyway, it's easier to just completely disable the tests until that PR fixes them.

(For context, MC/DC is currently unstable anyway, and LLVM's MC/DC APIs have changes between 18 and 19, so supporting both would be an unnecessary headache.)

r? jieyouxu

Currently these tests only run against LLVM 18, but the default is now LLVM 19,
which makes them very tricky to bless. Since rust-lang#126733 is going to drop support
for MC/DC in LLVM 18 anyway, it's easier to just completely disable the tests
until that PR fixes them.
@Zalathar Zalathar added the A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) label Oct 8, 2024
@rustbot

rustbot commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

Could not assign reviewer from: jieyouxu.
User(s) jieyouxu are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot

rustbot commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2024
@Zalathar

Zalathar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

I was originally hoping to avoid this by just approving #126733 myself, but that PR turns out to have bit-rotted slightly and needs a rebase.

@Zalathar

Zalathar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

@jieyouxu I believe you were annoyed by these tests recently so you have some context for why they should be disabled.

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Oct 8, 2024

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah I ran into this when trying to see if I can bless coverage tests for #130766 locally. The CI llvm got bumped to llvm 19, but these tests require llvm 18, and then becomes a PITA to bless.

@jieyouxu

jieyouxu commented Oct 8, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 729c140 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2024
@Zalathar

Zalathar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

Pulling this out of the queue because #126733 has been updated, so if that lands then this change becomes unnecessary.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2024
@bors

bors commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #126733) made this pull request unmergeable. Please resolve the merge conflicts.

@Zalathar

Zalathar commented Oct 8, 2024

Copy link
Copy Markdown
Member Author

Obsoleted by #126733.

@Zalathar Zalathar closed this Oct 8, 2024
@Zalathar Zalathar deleted the zombie-mcdc branch October 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants