crashes: more tests by matthiaskrgr · Pull Request #133294 · rust-lang/rust

matthiaskrgr · 2024-11-21T13:11:59Z

try-job: aarch64-apple
try-job: x86_64-msvc

jieyouxu

Thanks! I have some questions.

jieyouxu · 2024-11-21T13:27:23Z

@@ -0,0 +1,15 @@
+//@ known-bug: #133065
+//@compile-flags: -Zvalidate-mir -Zinline-mir -Zinline-mir-threshold=300


Suggestion: hmm, this is also one of those cases where it's better to identify which mir opts are involved, like #133104. Probably split this off into another PR.

as far as I understand this only enables mir inlining.
does Zinline-mir also enable other opts than mir inlining?

cc @saethlin do you know? I'm not super familiar with the MIR-specific ones.

I'm not too convinced that this is too useful in general.
If we for example have a broken mir opt in the pipeline, and the mir opt gets banished to -Zunsave-mir-opts, this still fixes the bug from a user perspective as the mir opt is no longer run by default.

Also some mir opts rely on each other which is why I don't fuzz single mir opts, as there are probably bunch of cases where "one opt will break if that other opt is not run before it."

Since this is a crashes test we can also remove it easily if it becomes a problem, so yeah it's a whatever.

does Zinline-mir also enable other opts than mir inlining?

-Zinline-mir is the same as -Zmir-enable-passes=+Inline, and it takes work to make sure those flags don't diverge in behavior.

there are probably bunch of cases where "one opt will break if that other opt is not run before it."

There aren't supposed to be any such cases.

If we for example have a broken mir opt in the pipeline, and the mir opt gets banished to -Zunsave-mir-opts, this still fixes the bug from a user perspective as the mir opt is no longer run by default.

The crashes tests aren't about tracking the quality of the user experience, they are about tracking the state of open issues. If an ICEing MIR opt is put behind a flag, the bug is still in the code.

jieyouxu · 2024-11-21T13:53:58Z

Thanks, r=me if the discussions indicate we can go ahead and add the relevant crashes tests.

jieyouxu

LGTM

jieyouxu · 2024-12-02T10:30:07Z

@rustbot author

matthiaskrgr · 2024-12-05T21:55:59Z

I've removed the ones that passed for now, will revisit these later
@bors r=jieyouxu

bors · 2024-12-05T21:56:02Z

📌 Commit 98bae8a has been approved by jieyouxu

It is now in the queue for this repository.

crashes: more tests r? `@jieyouxu`

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130777 (rust_for_linux: -Zreg-struct-return commandline flag for X86 (rust-lang#116973)) - rust-lang#133211 (Extend Miri to correctly pass mutable pointers through FFI) - rust-lang#133294 (crashes: more tests) - rust-lang#133790 (Improve documentation for Vec::extend_from_within) - rust-lang#133930 (rustbook: update to use new mdbook-trpl package from The Book) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-12-06T08:26:55Z

@bors r-

#133948 (comment)

jieyouxu · 2024-12-06T08:30:41Z

Maybe arch-specific ABI?

jieyouxu · 2024-12-08T13:59:26Z

@bors r+ rollup=iffy

bors · 2024-12-08T13:59:28Z

📌 Commit cd979c6 has been approved by jieyouxu

It is now in the queue for this repository.

crashes: more tests r? `@jieyouxu` try-job: aarch64-apple

bors · 2024-12-08T18:34:16Z

⌛ Testing commit cd979c6 with merge a41be64...

bors · 2024-12-08T19:29:24Z

💔 Test failed - checks-actions

jieyouxu · 2024-12-09T03:25:08Z

#132981 might be arch-specific?

@bors r-

matthiaskrgr · 2024-12-12T21:10:29Z

@bors try

ignore the test on windows entirely..

bors · 2024-12-12T21:11:41Z

⌛ Trying commit 33e6be0 with merge 1f04caa...

crashes: more tests r? `@jieyouxu` try-job: aarch64-apple try-job: x86_64-msvc

bors · 2024-12-12T23:03:06Z

☀️ Try build successful - checks-actions
Build commit: 1f04caa (1f04caae623a7116d715216b4ec1b995d1b92235)

jieyouxu · 2024-12-13T04:56:01Z

@bors r+

bors · 2024-12-13T04:56:04Z

📌 Commit 33e6be0 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2024-12-13T05:21:14Z

⌛ Testing commit 33e6be0 with merge 3da8bfb...

bors · 2024-12-13T08:00:48Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 3da8bfb to master...

rust-timer · 2024-12-13T09:19:48Z

Finished benchmarking commit (3da8bfb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.6%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.2%, 5.7%]	3
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[2.2%, 5.7%]	3

Cycles

Results (secondary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 771.968s -> 769.59s (-0.31%)
Artifact size: 331.01 MiB -> 331.01 MiB (-0.00%)

rustbot assigned jieyouxu Nov 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024

jieyouxu requested changes Nov 21, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024

matthiaskrgr force-pushed the crashes21nov branch from df9cef3 to 3f52fce Compare November 21, 2024 13:55

jieyouxu approved these changes Nov 21, 2024

View reviewed changes

jieyouxu closed this Dec 2, 2024

jieyouxu reopened this Dec 2, 2024

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2024

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2024

matthiaskrgr force-pushed the crashes21nov branch from 3f52fce to 98bae8a Compare December 4, 2024 23:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 5, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 6, 2024

Rollup merge of rust-lang#133294 - matthiaskrgr:crashes21nov, r=jieyouxu

e5c30ed

crashes: more tests r? `@jieyouxu`

matthiaskrgr mentioned this pull request Dec 6, 2024

Rollup of 5 pull requests #133948

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2024

matthiaskrgr force-pushed the crashes21nov branch from 98bae8a to cd979c6 Compare December 8, 2024 12:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024

Auto merge of rust-lang#133294 - matthiaskrgr:crashes21nov, r=jieyouxu

a41be64

crashes: more tests r? `@jieyouxu` try-job: aarch64-apple

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2024

crashes: more tests

33e6be0

matthiaskrgr force-pushed the crashes21nov branch from cd979c6 to 33e6be0 Compare December 12, 2024 21:09

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024

Auto merge of rust-lang#133294 - matthiaskrgr:crashes21nov, r=<try>

1f04caa

crashes: more tests r? `@jieyouxu` try-job: aarch64-apple try-job: x86_64-msvc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 13, 2024

bors merged commit 3da8bfb into rust-lang:master Dec 13, 2024

rustbot added this to the 1.85.0 milestone Dec 13, 2024

matthiaskrgr deleted the crashes21nov branch January 25, 2025 09:12

		@@ -0,0 +1,15 @@
		//@ known-bug: #133065
		//@compile-flags: -Zvalidate-mir -Zinline-mir -Zinline-mir-threshold=300

Uh oh!

Conversation

matthiaskrgr commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthiaskrgr Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Nov 21, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

jieyouxu commented Dec 2, 2024

Uh oh!

matthiaskrgr commented Dec 5, 2024

Uh oh!

bors commented Dec 5, 2024

Uh oh!

matthiaskrgr commented Dec 6, 2024

Uh oh!

jieyouxu commented Dec 6, 2024

Uh oh!

jieyouxu commented Dec 8, 2024

Uh oh!

bors commented Dec 8, 2024

Uh oh!

bors commented Dec 8, 2024

Uh oh!

This comment has been minimized.

bors commented Dec 8, 2024

Uh oh!

jieyouxu commented Dec 9, 2024

Uh oh!

matthiaskrgr commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Dec 12, 2024

Uh oh!

bors commented Dec 12, 2024

Uh oh!

jieyouxu commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

bors commented Dec 13, 2024

Uh oh!

rust-timer commented Dec 13, 2024

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

matthiaskrgr commented Nov 21, 2024 •

edited

Loading

matthiaskrgr Nov 21, 2024 •

edited

Loading

matthiaskrgr commented Dec 12, 2024 •

edited

Loading