Skip to content

Switch rtems target to panic unwind#133420

Merged
bors merged 1 commit into
rust-lang:masterfrom
thesummer:rtems-unwind
Jan 4, 2025
Merged

Switch rtems target to panic unwind#133420
bors merged 1 commit into
rust-lang:masterfrom
thesummer:rtems-unwind

Conversation

@thesummer

@thesummer thesummer commented Nov 24, 2024

Copy link
Copy Markdown
Contributor

Switch the RTEMS target to panic_unwind.

Relates to rust-lang/backtrace-rs#682

@rustbot

rustbot commented Nov 24, 2024

Copy link
Copy Markdown
Collaborator

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 24, 2024
@rustbot

rustbot commented Nov 24, 2024

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@bors

bors commented Nov 30, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #133533) made this pull request unmergeable. Please resolve the merge conflicts.

@thesummer

Copy link
Copy Markdown
Contributor Author

@workingjubilee I hope the release stress from the last release is over. Could you please have a look at this PR?

Integrating it even without the update to the backtrace submodule would already help me to experiment with some unit test setups.

@tgross35

Copy link
Copy Markdown
Contributor

The changes here look reasonable to me but the backtrace changes need to merge before this right?

@thesummer

Copy link
Copy Markdown
Contributor Author

@tgross35 I think it is save to merge this one here first as well. Currently the port also requires that backtrace is updated locally, so merging this won't change that.

@tgross35

Copy link
Copy Markdown
Contributor

The backtrace change is so small that maybe we should just try to get that in around the same time. @workingjubilee is backtrace stuck from CI failures or could rust-lang/backtrace-rs#682 get into a release soonish?

@thesummer

Copy link
Copy Markdown
Contributor Author

@tgross35 Updating the backtrace submodule was blocked by some performance metrics (see this PR #130417).

I am not sure if the CI failures of rust-lang/backtrace-rs#682 are related to that.

@workingjubilee

Copy link
Copy Markdown
Member

confused. If this was all that was needed, why wasn't it just done from the get-go...?

@workingjubilee

Copy link
Copy Markdown
Member

Most of the CI failures in backtrace have nothing to do with the ruzstd merge and can simply be fixed by fixing them.

@workingjubilee

workingjubilee commented Jan 2, 2025

Copy link
Copy Markdown
Member

CI will be fixed enough when rust-lang/backtrace-rs#687 rust-lang/backtrace-rs#679 merges

@thesummer

Copy link
Copy Markdown
Contributor Author

@workingjubilee Sorry, for the confusion. I am new to rust compiler development and was working myself upwards from a bare-metal/panic abort system to RTEMS support.

Happy New Year btw.

@workingjubilee

workingjubilee commented Jan 3, 2025

Copy link
Copy Markdown
Member

As of #135053 we now have a backtrace version that includes the libunwind change for the RTEMS target and builds without zstd support, thus without immediately requiring us to bring in ruzstd, thus without immediately addressing any performance questions.

This is a tier 3 target so I am entitled to ship a change recklessly to it without heed to whether it still builds1. MUAHAHAHA!

@bors r+ rollup

Footnotes

  1. ...also it's at the maintainer's request.

@bors

bors commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 3f94047 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
@thesummer

Copy link
Copy Markdown
Contributor Author

@workingjubilee thanks a lot. Also for your efforts to punch through the CI problems in the backtrace repo.

@bors bors merged commit 4cd2895 into rust-lang:master Jan 4, 2025
@rustbot rustbot added this to the 1.86.0 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants