Skip to content

Document powf and powi values that are always 1.0 (f32)#136013

Closed
hkBst wants to merge 3 commits into
rust-lang:masterfrom
hkBst:patch-23
Closed

Document powf and powi values that are always 1.0 (f32)#136013
hkBst wants to merge 3 commits into
rust-lang:masterfrom
hkBst:patch-23

Conversation

@hkBst

@hkBst hkBst commented Jan 24, 2025

Copy link
Copy Markdown
Member

f32 part for bug #90429

@rustbot

rustbot commented Jan 24, 2025

Copy link
Copy Markdown
Collaborator

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2025
Comment thread library/std/src/f32.rs Outdated
hkBst and others added 2 commits January 24, 2025 18:19
Co-authored-by: matthewjasper <20113453+matthewjasper@users.noreply.github.com>
@matthiaskrgr

Copy link
Copy Markdown
Member

#136012
#136013
#136014
#136015

wouldn't it make sense to squash all of these into a single commit?

@hkBst

hkBst commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

@matthiaskrgr maybe if the effort to payout ratio was better?

EDIT: I meant "payoff" here, not "payout"! But I can see that I misjudged the value people place on this...

@matthiaskrgr

Copy link
Copy Markdown
Member

The way I see it, it takes much more effort for 3-4 people to review each of these PRs individually instead of having one person just look at one PR that incorporates all the changes at once.

Just need to merge all the branches into a single one and then rebase into a single commit, that should only take a minute or two. 🙂

@hkBst

hkBst commented Jan 24, 2025

Copy link
Copy Markdown
Member Author

@matthiaskrgr the amount to review won't change, and there is nothing stopping the first reviewer from picking up the other three...

@compiler-errors

Copy link
Copy Markdown
Contributor

Please merge this into #136012 and avoid opening up 4 PRs -- there's no reason to split this over 4 PRs, since they all work towards the same goal.

@hkBst hkBst deleted the patch-23 branch January 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants