std: move process implementations to `sys` by joboet · Pull Request #136929 · rust-lang/rust

joboet · 2025-02-12T15:27:14Z

As per #117276, this moves the implementations of Process and friends out of the pal module and into the sys module, removing quite a lot of error-prone #[path] imports in the process (hah, get it ;-)). I've also made the zircon module a dedicated submodule of pal::unix, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in sys). Also, the ensure_no_nuls function on Windows now lives in sys::pal::windows – it's not specific to processes and shared by the argument implementation.

rustbot · 2025-02-12T15:27:23Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

bors · 2025-02-15T04:34:34Z

☔ The latest upstream changes (presumably #137046) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-17T12:14:45Z

☔ The latest upstream changes (presumably #137163) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-23T05:56:26Z

☔ The latest upstream changes (presumably #137446) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum

non-blocking question

Mark-Simulacrum · 2025-03-01T20:10:08Z

 }

+pub fn ensure_no_nuls<T: AsRef<OsStr>>(s: T) -> crate::io::Result<T> {
+    if s.as_ref().encode_wide().any(|b| b == 0) {


Hm, are we using this for soundness anywhere? The AsRef<OsStr> conversion could e.g. return different results spuriously which would be a problem if we are.

Luckily that's not the case, we only use this with trusted types. But I agree that this isn't great, I'll try to find a better solution in another PR.

Mark-Simulacrum · 2025-03-01T20:10:52Z

r=me with a rebase

bors · 2025-03-12T01:03:51Z

☔ The latest upstream changes (presumably #138366) made this pull request unmergeable. Please resolve the merge conflicts.

Mark-Simulacrum · 2025-03-15T14:26:57Z

@rustbot author

(Feel free to self-approve, I believe you have permissions, as you rebase)

joboet · 2025-03-16T08:59:21Z

@rustbot author

(Feel free to self-approve, I believe you have permissions, as you rebase)

Will do! Most of the time, I just want to wait until the CI shows green, but then forget to approve the PR until it's too late again... 😄

@bors r=@Mark-Simulacrum

joboet · 2025-03-17T10:20:44Z

That failure seems spurious...
@bors retry

As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

joboet · 2025-03-22T11:45:26Z

@bors r-

joboet · 2025-03-22T14:09:19Z

Rebased.
@bors r=@Mark-Simulacrum

bors · 2025-03-22T14:09:21Z

📌 Commit 89f85cb has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2025-03-23T14:10:38Z

⌛ Testing commit 89f85cb with merge aa8f0fd...

bors · 2025-03-23T17:17:09Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing aa8f0fd to master...

github-actions · 2025-03-23T17:18:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 97fc1f6 (parent) -> aa8f0fd (this PR)

Test differences

Show 48 test diffs

sys::pal::unix::process::process_common::tests::test_process_group_no_posix_spawn (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_common::tests::test_process_group_posix_spawn (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_common::tests::test_process_mask (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_common::tests::test_program_kind (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_common::tests::unix_exit_statuses (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_inner::process_unsupported_wait_status::tests::compare_with_linux (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_inner::tests::exitstatus_display_tests (stage 0): pass -> [missing] (J0)
sys::pal::unix::process::process_inner::tests::test_command_fork_no_unwind (stage 0): pass -> [missing] (J0)
sys::process::unix::common::tests::test_process_group_no_posix_spawn (stage 0): [missing] -> pass (J0)
sys::process::unix::common::tests::test_process_group_posix_spawn (stage 0): [missing] -> pass (J0)
sys::process::unix::common::tests::test_process_mask (stage 0): [missing] -> pass (J0)
sys::process::unix::common::tests::test_program_kind (stage 0): [missing] -> pass (J0)
sys::process::unix::common::tests::unix_exit_statuses (stage 0): [missing] -> pass (J0)
sys::process::unix::unix::tests::exitstatus_display_tests (stage 0): [missing] -> pass (J0)
sys::process::unix::unix::tests::test_command_fork_no_unwind (stage 0): [missing] -> pass (J0)
sys::process::unix::unix::unsupported_wait_status::tests::compare_with_linux (stage 0): [missing] -> pass (J0)
sys::pal::unix::process::process_common::tests::test_program_kind (stage 1): pass -> [missing] (J1)
sys::pal::unix::process::process_common::tests::unix_exit_statuses (stage 1): pass -> [missing] (J1)
sys::pal::unix::process::process_inner::tests::exitstatus_display_tests (stage 1): pass -> [missing] (J1)
sys::pal::unix::process::process_inner::tests::test_command_fork_no_unwind (stage 1): pass -> [missing] (J1)
sys::process::unix::common::tests::test_program_kind (stage 1): [missing] -> pass (J1)
sys::process::unix::common::tests::unix_exit_statuses (stage 1): [missing] -> pass (J1)
sys::process::unix::unix::tests::exitstatus_display_tests (stage 1): [missing] -> pass (J1)
sys::process::unix::unix::tests::test_command_fork_no_unwind (stage 1): [missing] -> pass (J1)
sys::pal::unix::process::process_common::tests::test_process_group_no_posix_spawn (stage 1): ignore -> [missing] (J2)
sys::pal::unix::process::process_common::tests::test_process_group_posix_spawn (stage 1): ignore -> [missing] (J2)
sys::pal::unix::process::process_common::tests::test_process_mask (stage 1): ignore -> [missing] (J2)
sys::process::unix::common::tests::test_process_group_no_posix_spawn (stage 1): [missing] -> ignore (J2)
sys::process::unix::common::tests::test_process_group_posix_spawn (stage 1): [missing] -> ignore (J2)
sys::process::unix::common::tests::test_process_mask (stage 1): [missing] -> ignore (J2)
sys::pal::windows::process::tests::test_make_command_line (stage 1): pass -> [missing] (J3)
sys::pal::windows::process::tests::test_raw_args (stage 1): pass -> [missing] (J3)
sys::pal::windows::process::tests::test_thread_handle (stage 1): pass -> [missing] (J3)
sys::pal::windows::process::tests::windows_env_unicode_case (stage 1): pass -> [missing] (J3)
sys::pal::windows::process::tests::windows_exe_resolver (stage 1): pass -> [missing] (J3)
sys::process::windows::tests::test_make_command_line (stage 1): [missing] -> pass (J3)
sys::process::windows::tests::test_raw_args (stage 1): [missing] -> pass (J3)
sys::process::windows::tests::test_thread_handle (stage 1): [missing] -> pass (J3)
sys::process::windows::tests::windows_env_unicode_case (stage 1): [missing] -> pass (J3)
sys::process::windows::tests::windows_exe_resolver (stage 1): [missing] -> pass (J3)
sys::pal::unix::process::process_inner::process_unsupported_wait_status::tests::compare_with_linux (stage 1): pass -> [missing] (J4)
sys::process::unix::unix::unsupported_wait_status::tests::compare_with_linux (stage 1): [missing] -> pass (J4)
sys::pal::unix::process::process_common::tests::test_process_group_no_posix_spawn (stage 1): pass -> [missing] (J5)
sys::pal::unix::process::process_common::tests::test_process_group_posix_spawn (stage 1): pass -> [missing] (J5)
sys::pal::unix::process::process_common::tests::test_process_mask (stage 1): pass -> [missing] (J5)
sys::process::unix::common::tests::test_process_group_no_posix_spawn (stage 1): [missing] -> pass (J5)
sys::process::unix::common::tests::test_process_group_posix_spawn (stage 1): [missing] -> pass (J5)
sys::process::unix::common::tests::test_process_mask (stage 1): [missing] -> pass (J5)

Job group index

J0: mingw-check
J1: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-19-3, x86_64-gnu-nopt, x86_64-gnu-stable
J2: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, x86_64-apple-1
J3: i686-msvc-1, x86_64-mingw-1, x86_64-msvc-1
J4: aarch64-gnu, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, test-various, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-19-3, x86_64-gnu-nopt, x86_64-gnu-stable
J5: dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, test-various, x86_64-gnu, x86_64-gnu-llvm-18-1, x86_64-gnu-llvm-18-2, x86_64-gnu-llvm-18-3, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-19-3, x86_64-gnu-nopt, x86_64-gnu-stable

rust-timer · 2025-03-23T18:35:11Z

Finished benchmarking commit (aa8f0fd): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[1.6%, 2.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.8%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.3%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.27s -> 775.713s (0.06%)
Artifact size: 365.52 MiB -> 365.52 MiB (-0.00%)

PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account.

…Poison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

Rollup merge of rust-lang#138875 - thaliaarchi:trusty-build, r=randomPoison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

…lacrum std: move process implementations to `sys` As per rust-lang#117276, this moves the implementations of `Process` and friends out of the `pal` module and into the `sys` module, removing quite a lot of error-prone `#[path]` imports in the process (hah, get it ;-)). I've also made the `zircon` module a dedicated submodule of `pal::unix`, hopefully we can move some other definitions there as well (they are currently quite a lot of duplications in `sys`). Also, the `ensure_no_nuls` function on Windows now lives in `sys::pal::windows` – it's not specific to processes and shared by the argument implementation.

PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account.

…Poison,saethlin Trusty: Fix build for anonymous pipes and std::sys::process PRs rust-lang#136842 (Add libstd support for Trusty targets), rust-lang#137793 (Stablize anonymous pipe), and rust-lang#136929 (std: move process implementations to `sys`) merged around the same time, so update Trusty to take them into account. cc `@randomPoison`

rustbot assigned Mark-Simulacrum Feb 12, 2025

joboet mentioned this pull request Feb 12, 2025

Tracking Issue for restructuring std::sys #117276

Open

32 tasks

This comment has been minimized.

Sign in to view

joboet force-pushed the move_process_pal branch from a3a3339 to 484706e Compare February 12, 2025 15:40

This comment has been minimized.

Sign in to view

joboet force-pushed the move_process_pal branch from 484706e to 5ce9e2c Compare February 13, 2025 11:00

joboet force-pushed the move_process_pal branch from 5ce9e2c to fb1751f Compare February 15, 2025 12:43

joboet force-pushed the move_process_pal branch from fb1751f to 26fd9bf Compare February 17, 2025 12:57

Mark-Simulacrum approved these changes Mar 1, 2025

View reviewed changes

joboet force-pushed the move_process_pal branch from 26fd9bf to 57462c0 Compare March 11, 2025 10:54

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2025

joboet force-pushed the move_process_pal branch from 57462c0 to af6d150 Compare March 15, 2025 16:10

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 17, 2025

joboet force-pushed the move_process_pal branch from af6d150 to 89f85cb Compare March 22, 2025 11:44

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 23, 2025

bors merged commit aa8f0fd into rust-lang:master Mar 23, 2025

rustbot added this to the 1.87.0 milestone Mar 23, 2025

This was referenced Mar 23, 2025

Create Atomic<T> type alias (rebase) #136316

Merged

Add std::os::unix::process::CommandExt::chroot to safely chroot a child process #137759

Merged

thaliaarchi mentioned this pull request Mar 24, 2025

Trusty: Fix build for anonymous pipes and std::sys::process #138875

Merged

zjp-CN mentioned this pull request Jan 17, 2026

API changes in std.json os-checker/unsafety-propagation-graph#23

Closed

Uh oh!

Conversation

joboet commented Feb 12, 2025

Uh oh!

rustbot commented Feb 12, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Feb 15, 2025

Uh oh!

bors commented Feb 17, 2025

Uh oh!

bors commented Feb 23, 2025

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum Mar 1, 2025

Choose a reason for hiding this comment

Uh oh!

joboet Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

Mark-Simulacrum commented Mar 1, 2025

Uh oh!

bors commented Mar 12, 2025

Uh oh!

Mark-Simulacrum commented Mar 15, 2025

Uh oh!

joboet commented Mar 16, 2025

Uh oh!

joboet commented Mar 17, 2025

Uh oh!

joboet commented Mar 22, 2025

Uh oh!

joboet commented Mar 22, 2025

Uh oh!

bors commented Mar 22, 2025

Uh oh!

bors commented Mar 23, 2025

Uh oh!

bors commented Mar 23, 2025

Uh oh!

github-actions Bot commented Mar 23, 2025

Test differences

Uh oh!

rust-timer commented Mar 23, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants