Port #[may_dangle] to the new attribute system#142539
Merged
Merged
Conversation
rustbot
added
A-attributes
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
| // FIXME: should not be needed anymore when all attrs are parsed | ||
| Attribute::Parsed(AttributeKind::Deprecation { span, .. }) => *span, | ||
| Attribute::Parsed(AttributeKind::DocComment { span, .. }) => *span, | ||
| Attribute::Parsed(AttributeKind::MayDangle(span)) => *span, |
Contributor
There was a problem hiding this comment.
same feedback as on the other PR. This list should be kept as small as possible and was only introduced for migration purposes. I expect this entire function to be removed.
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-blocked
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
f2ffea0 to
d4006e4
Compare
Contributor
Author
rustbot
added
S-waiting-on-review
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
d4006e4 to
76dfb1c
Compare
Collaborator
|
☔ The latest upstream changes (presumably #138165) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
@GrigorenkoPV could you rebase? Then I'll give it one more pass and we can merge |
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
76dfb1c to
1ddede1
Compare
Collaborator
|
☔ The latest upstream changes (presumably #142697) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
1ddede1 to
37bc3f6
Compare
| self.check_applied_to_fn_or_method(hir_id, *attr_span, span, target) | ||
| } | ||
| &Attribute::Parsed(AttributeKind::MayDangle(attr_span)) => { | ||
| // Check if `#[may_dangle]` is applied to a lifetime or type generic parameter in `Drop` impl. |
Contributor
There was a problem hiding this comment.
this should be in its own function, not here, just like other validation logic usually isn't
Collaborator
|
☔ The latest upstream changes (presumably #142770) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/may_dangle
branch
from
37bc3f6 to
045faa8
Compare
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
This was referenced Jun 21, 2025
bors
added a commit
that referenced
this pull request
Jun 21, 2025
Rollup of 3 pull requests Successful merges: - #142539 (Port `#[may_dangle]` to the new attribute system) - #142690 (expand: Remove some unnecessary generic parameters) - #142698 (Improve diagnostics for `concat_bytes!` with C string literals) Failed merges: - #142600 (Port `#[rustc_pub_transparent]` to the new attribute system) - #142776 (All HIR attributes are outer) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to #142498.
This is a part of #131229, so
r? @jdonszelmann