Skip to content

doc attribute parsing errors: Revert #151952#152221

Open
GuillaumeGomez wants to merge 5 commits into
rust-lang:mainfrom
GuillaumeGomez:revert-revert-doc-errors
Open

doc attribute parsing errors: Revert #151952#152221
GuillaumeGomez wants to merge 5 commits into
rust-lang:mainfrom
GuillaumeGomez:revert-revert-doc-errors

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Feb 6, 2026

Copy link
Copy Markdown
Member

Reverts #151952.

Since it's now backported with the "future error" warning, we can remove these changes.

r? @JonathanBrouwer

@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 6, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Can we add tests for the three cases in #151865 (comment)
After that I think this needs T-rustdoc approval since it's a breaking change
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Added the test.

@rust-bors

This comment has been minimized.

@JonathanBrouwer JonathanBrouwer added S-waiting-on-t-rustdoc Status: Awaiting decision from T-rustdoc and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@GuillaumeGomez GuillaumeGomez force-pushed the revert-revert-doc-errors branch from 5e5b37b to d8527e6 Compare February 9, 2026 13:44
@rustbot

rustbot commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Fixed merge conflict. I'll mention this PR at tonight's meeting.

@GuillaumeGomez

GuillaumeGomez commented Feb 9, 2026

Copy link
Copy Markdown
Member Author

The rustdoc team decided to keep them as warnings (in this discussion), based on this discussion.

So I'll instead improve the warnings and remove the "future deprecated" part.

@rust-bors

rust-bors Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #152324) made this pull request unmergeable. Please resolve the merge conflicts.

@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-t-rustdoc Status: Awaiting decision from T-rustdoc labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants