add no-writable attribute and flag#154946
Closed
quiode wants to merge 2 commits into
Closed
Conversation
rustbot
added
A-attributes
Member
|
hi, thanks for you contribution and sorry for the following quesitons, but why is this needed? is there proposal for adding this or maybe issue explaining the problem that this pr is trying to address? |
This was referenced Apr 7, 2026
Contributor
Author
|
r? @RalfJung |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
Member
|
thanks for updating pr description for more context |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Redddy <midzy0228@gmail.com>
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to address rust-lang/unsafe-code-guidelines#584 (comment). It is part of a bachelor thesis supervised by @JoJoDeveloping and @RalfJung, for more information, see: Project_Description.pdf.
This PR adds the
#[rustc_no_writable]attribute and the-Zno-writableflag. They currently have no effect, but are used in #154948 and #154949. The flag should have the same effect as the attribute, just applied globally instead of a per function basis. They should turn off the checking in miri and the addition of the llvm attribute in, better explained in the respective PR's.