resolve: Make sure visibilities of import declarations make sense by petrochenkov · Pull Request #155213 · rust-lang/rust

petrochenkov · 2026-04-12T20:57:03Z

That they are all ordered inside the module and not more private than the module itself.

The import_decl_vis logic is also reused when reporting ambiguous_import_visibilities lint.
Some asserts are hardened.
Some relevant tests are added.

Extracted from #154149.

rustbot · 2026-04-12T20:57:10Z

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 11 candidates

petrochenkov · 2026-04-12T20:57:33Z

cc @yaahc

petrochenkov · 2026-04-12T20:58:56Z

To make sure the asserts are not expensive.
@bors try @rust-timer queue

resolve: Make sure visibilities of import declarations make sense

rust-bors · 2026-04-12T23:06:50Z

☀️ Try build successful (CI)
Build commit: 89a90f3 (89a90f39ff9b6aadf1ca3a80a26c38deb2592682, parent: 14196dbfa3eb7c30195251eac092b1b86c8a2d84)

rust-timer · 2026-04-12T23:47:33Z

Finished benchmarking commit (89a90f3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.5%, secondary -6.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.7%	[-6.7%, -6.7%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Cycles

Results (primary -2.6%, secondary 11.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	11.4%	[2.7%, 25.8%]	3
Improvements ✅ (primary)	-2.6%	[-3.0%, -2.3%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-3.0%, -2.3%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.114s -> 490.825s (-0.06%)
Artifact size: 394.23 MiB -> 394.30 MiB (0.02%)

petrochenkov · 2026-04-16T08:30:34Z

r? @mu001999
@bors rollup=maybe

rustbot · 2026-04-16T08:30:40Z

mu001999 is currently at their maximum review capacity.
They may take a while to respond.

jdonszelmann · 2026-04-17T12:12:41Z

@rustbot reroll

…al modules

That they are all ordered inside the module and not more private than the module itself The `import_decl_vis` logic is reused when reporting `ambiguous_import_visibilities` lint Some asserts are hardened Some relevant tests are added

rustbot · 2026-04-20T10:52:53Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-04-20T10:54:13Z

Rebased and updated.

mu001999 · 2026-04-20T11:09:07Z

@bors r+

rust-bors · 2026-04-20T11:09:10Z

📌 Commit 394c717 has been approved by mu001999

It is now in the queue for this repository.

…uwer Rollup of 11 pull requests Successful merges: - #154654 (Move `std::io::ErrorKind` to `core::io`) - #145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - #154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - #155213 (resolve: Make sure visibilities of import declarations make sense) - #155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - #155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - #155549 (Remove some unnecessary lifetimes.) - #154248 (resolve : mark repr_simd as internal) - #154772 (slightly optimize the `non-camel-case-types` lint) - #155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - #155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)

Rollup merge of #155213 - petrochenkov:importvis, r=mu001999 resolve: Make sure visibilities of import declarations make sense That they are all ordered inside the module and not more private than the module itself. The `import_decl_vis` logic is also reused when reporting `ambiguous_import_visibilities` lint. Some asserts are hardened. Some relevant tests are added. Extracted from #154149.

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#154654 (Move `std::io::ErrorKind` to `core::io`) - rust-lang/rust#145270 (Fix an ICE observed with an explicit tail-call in a default trait method) - rust-lang/rust#154895 (borrowck: Apply `user_arg_index` nomenclature more broadly) - rust-lang/rust#155213 (resolve: Make sure visibilities of import declarations make sense) - rust-lang/rust#155346 (`single_use_lifetimes`: respect `anonymous_lifetime_in_impl_trait`) - rust-lang/rust#155517 (Add a test for Mach-O `#[link_section]` API inherited from LLVM) - rust-lang/rust#155549 (Remove some unnecessary lifetimes.) - rust-lang/rust#154248 (resolve : mark repr_simd as internal) - rust-lang/rust#154772 (slightly optimize the `non-camel-case-types` lint) - rust-lang/rust#155541 (Add `#[rust_analyzer::prefer_underscore_import]` to the traits in `rustc_type_ir::inherent`) - rust-lang/rust#155544 (bootstrap: Make "detected modifications" for download-rustc less verbose)

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

@mu001999

Rollup merge of #156014 - petrochenkov:kvak, r=mu001999 resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging #155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from #155257, #155213, #154149, etc. r? @mu001999

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang/rust#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang/rust#155257, rust-lang/rust#155213, rust-lang/rust#154149, etc. r? @mu001999

rustbot assigned jdonszelmann Apr 12, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2026

petrochenkov mentioned this pull request Apr 12, 2026

resolve: Extend ambiguous_import_visibilities deprecation lint to glob-vs-glob ambiguities #154149

Merged