Skip to content

Remove AttributeLintKind variants - part 6#155661

Merged
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
GuillaumeGomez:rm-attributelintkind
Apr 23, 2026
Merged

Remove AttributeLintKind variants - part 6#155661
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
GuillaumeGomez:rm-attributelintkind

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Apr 22, 2026

Copy link
Copy Markdown
Member

@rustbot

rustbot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to diagnostic attributes.

cc @mejrs

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2026
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 22, 2026
Open
3 tasks
@rust-bors

This comment has been minimized.

Sign in to view
@mejrs

mejrs commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I just pushed #155662 which makes some changes to diagnostic format arg parsing (migrating the lint it in the process). Would you be willing to drop AttributeLintKind::MalformedDiagnosticFormat from this PR?

@GuillaumeGomez

GuillaumeGomez commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

I'm about to completely remove AttributeLintKind today so it might be simpler for you to wait until this PR and the next one are merged. I have 5 remaining variants to remove so should be pretty quick.

@rustbot

rustbot commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer
JonathanBrouwer approved these changes Apr 23, 2026
View reviewed changes

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup
Let's merge this first, rebasing on this shouldn't be too difficult I think

View changes since this review

@rust-bors

rust-bors Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b716ebc has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2026
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 23, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Apr 23, 2026
@bors
Auto merge of #155687 - GuillaumeGomez:rollup-aZ7YrAD, r=GuillaumeGomez
36ba2c7 
Rollup of 7 pull requests

Successful merges:

 - #155469 (Account for titlecase in casing lints)
 - #155644 (delegation: support self ty propagation for functions in free to trait reuse)
 - #154957 (Fix ICE when const closure appears inside a non-const trait method)
 - #155442 (Change keyword order for `impl` restrictions)
 - #155561 (Use singular wording for single _ placeholders in type suggestions)
 - #155637 (Fix E0191 suggestion for empty dyn trait args)
 - #155661 (Remove `AttributeLintKind` variants - part 6)
@rust-bors rust-bors Bot merged commit 0a4e73e into rust-lang:main Apr 23, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Apr 23, 2026
@rust-timer
Unrolled build for #155661
65334c7 
Rollup merge of #155661 - GuillaumeGomez:rm-attributelintkind, r=JonathanBrouwer

Remove `AttributeLintKind` variants - part 6

Part of #153099.

r? @JonathanBrouwer
@rustbot rustbot added this to the 1.97.0 milestone Apr 23, 2026
@GuillaumeGomez GuillaumeGomez deleted the rm-attributelintkind branch April 23, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rustbot @mejrs @JonathanBrouwer