Skip to content

Rollup of 4 pull requests#156438

Closed
JonathanBrouwer wants to merge 9 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-yUULabN
Closed

Rollup of 4 pull requests#156438
JonathanBrouwer wants to merge 9 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-yUULabN

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

RalfJung and others added 9 commits May 9, 2026 14:31
tests: ip*_properties: avoid parsing the IP over and over again

This test somehow takes 12s to execute in Miri (on CI, i.e. on a slow machine), despite not having any loop. I suspect it's caused by us for some reason re-parsing the same string again and again. Let's just not do that.
prepare fs tests for miri

- reduce iteration counts to get rid of timeouts
- disable one test that relies on spawning processes
resolve: Module-related refactorings

Extracted parts of rust-lang#156362 that don't require splitting `(Local,Extern)ModuleData` into separate data structures.

- Some `expect_local` assertions are added
- Methods that need to exist on all of `Module` and `(Local,Extern)Module` are implemented for `ModuleData`
- Methods that need to exist on `ModuleKind` are moved to `ModuleKind`
- Some unnecessary complicated logic using `graph_root` is simplified
-  `glob_importers` are filled and used only for local modules.
- Some unnecessary logic is skipped for extern modules in `resolve_ident_in_module_non_globs_unadjusted`
- Module construction functions are cleaned up
- `module_to_string` is simplified

r? @nnethercote
…egers, r=Urgau

Fix unwanted "Available on XX-bit only" in libcore integers

Fixes rust-lang#149786.

The problem came from:

<img width="754" height="734" alt="image" src="https://github.com/user-attachments/assets/c251326f-8640-420d-bc4c-a3246390ea67" />

The `doc_cfg` feature picks the `cfg` as it should. If we don't want it, we simply need to disable the feature on it. With this fix, no more `cfg` annotations:

<img width="860" height="590" alt="image" src="https://github.com/user-attachments/assets/da793590-bf43-4874-94e1-a56809938420" />

r? @Urgau
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 11, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 11, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2654729 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 11, 2026
Rollup of 4 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2654729 with merge 62c19b4...

Workflow: https://github.com/rust-lang/rust/actions/runs/25657261992

rust-bors Bot pushed a commit that referenced this pull request May 11, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156357 (tests: ip*_properties: avoid parsing the IP over and over again)
 - #156389 (prepare fs tests for miri)
 - #156406 (resolve: Module-related refactorings)
 - #156426 (Fix unwanted "Available on XX-bit only" in libcore integers)
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors yield
Yielding to the bigger rollup

@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #156434.

rust-bors Bot pushed a commit that referenced this pull request May 11, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156357 (tests: ip*_properties: avoid parsing the IP over and over again)
 - #156389 (prepare fs tests for miri)
 - #156406 (resolve: Module-related refactorings)
 - #156426 (Fix unwanted "Available on XX-bit only" in libcore integers)
@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit 2654729 with merge 4e6d357...

Workflow: https://github.com/rust-lang/rust/actions/runs/25658008534

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2026
@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved due to being closed.

Auto build was cancelled due to the PR being closed. Cancelled workflows:

@rust-bors

rust-bors Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 7c41dd7 failed: CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants