Extend capabilities of TypeFoldable_Generic#157695
Open
Jamesbarford wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
lcnr
reviewed
Jun 10, 2026
Jamesbarford
force-pushed
the
feat/extend-type-foldable-generic
branch
from
eacc8f6 to
0a4fcf1
Compare
lcnr
reviewed
Jun 11, 2026
Contributor
|
unfortunate to not use these changes in the same PR, but it's fine 😁 @bors delegate+ |
Contributor
|
✌️ @Jamesbarford, you can now approve this pull request! If @lcnr told you to " |
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Contributor
Author
|
@bors r=lcnr |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 11, 2026
…able-generic, r=lcnr Extend capabilities of `TypeFoldable_Generic` Split from rust-lang#156538. - Lets `TypeFoldable_Generic` derive structural folding for types with extra generic parameters by adding the necessary `T: TypeFoldable<I>` bounds automatically - Means in rust-lang#156538 we can remove the manual `TypeFoldable` implementation for `NormalizesTo` - Refactors shared traversal logic between `Lift_Generic` and `TypeFoldable_Generic` into a shared helper with a callback. r? @lcnr
rust-bors
Bot
added
S-waiting-on-author
rustbot
added
the
T-bootstrap
Contributor
|
This pull request was unapproved. This PR was contained in a rollup (#157759), which was closed. |
This comment has been minimized.
This comment has been minimized.
Shourya742
reviewed
Jun 11, 2026
Jamesbarford
force-pushed
the
feat/extend-type-foldable-generic
branch
from
c37c6d2 to
23e03d9
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #156538.
TypeFoldable_Genericderive structural folding for types with extra generic parameters by adding the necessaryT: TypeFoldable<I>bounds automaticallyAliasTy&AliasTermto useAlias#156538 we can remove the manualTypeFoldableimplementation forNormalizesToLift_GenericandTypeFoldable_Genericinto a shared helper with a callback.r? @lcnr