Skip to content

Deny todo!() in tidy#157706

Open
jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:deny-todo
Open

Deny todo!() in tidy#157706
jdonszelmann wants to merge 4 commits into
rust-lang:mainfrom
jdonszelmann:deny-todo

Conversation

@jdonszelmann

@jdonszelmann jdonszelmann commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in rustc_ty_utils::consts.rs

cc @BoxyUwU

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend A-tidy Area: The tidy tool PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 10, 2026
@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

WaffleLapkin
WaffleLapkin reviewed Jun 10, 2026
View reviewed changes
Comment thread library/std/src/sys/net/connection/uefi/mod.rs
Comment on lines 148 to 211
@@ -206,7 +206,7 @@ impl TcpListener {

impl fmt::Debug for TcpListener {
fn fmt(&self, _f: &mut fmt::Formatter<'_>) -> fmt::Result {
todo!()
unimplemented!()
}
}

@WaffleLapkin WaffleLapkin Jun 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure how much uefi target maintainers care about this, but they would probably like to be able to search for this? Could you maybe add fixmes?

View changes since the review

Comment thread compiler/rustc_ast_passes/src/diagnostics.rs
Comment on lines +970 to 971
// ignore-tidy-todo
code = " => {{ todo!() }}",

@WaffleLapkin WaffleLapkin Jun 10, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is imo confusing. From what I can tell // ignore-tidy-... annotations are file global. This disables the check for the whole file, not this line...

View changes since the review

@rust-bors

rust-bors Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #157739) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Kivooeo Kivooeo

Labels

A-rustdoc-json Area: Rustdoc JSON backend A-tidy Area: The tidy tool PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jdonszelmann @rustbot @WaffleLapkin @Kivooeo