Skip to content

Update clippy#62434

Merged
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:clippyup
Jul 7, 2019
Merged

Update clippy#62434
bors merged 1 commit into
rust-lang:masterfrom
Manishearth:clippyup

Conversation

@Manishearth

@Manishearth Manishearth commented Jul 6, 2019

Copy link
Copy Markdown
Member

r? @ghost

@Manishearth

Manishearth commented Jul 6, 2019

Copy link
Copy Markdown
Member Author

@bors r+ p=2

@bors

bors commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 36a67339d076634fdf548b1e12e24ca37431ffd7 has been approved by Manishearth

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 6, 2019
@matthiaskrgr

matthiaskrgr commented Jul 6, 2019

Copy link
Copy Markdown
Member

If #61988 merges, clippy will be broken again (regardless of this pr).

@tesuji tesuji mentioned this pull request Jul 6, 2019
Closed
@bors

bors commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 36a67339d076634fdf548b1e12e24ca37431ffd7 with merge c8eafa56334528b48d394efe40d231b2bbdd777d...

@tesuji

tesuji commented Jul 6, 2019

Copy link
Copy Markdown
Contributor

@Centril Do you want to take a look to rustup clippy?

@bors

bors commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2019
@Centril

Centril commented Jul 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@lzutao Don't have time for it right now. It should be relatively straightforward tho... make a "higher" function for resugaring while-loops (like as done for if-expressions) with the information you need using the desugaring information based on what is done in lowering.rs in my PR. Then proceed to use that higher function on HIR expressions and match on Some((the, information, you need)).

@Manishearth

Manishearth commented Jul 7, 2019

Copy link
Copy Markdown
Member Author

@bors r+

@bors

bors commented Jul 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit e2885eb has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2019
@bors

bors commented Jul 7, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e2885eb with merge dbeed58...

bors added a commit that referenced this pull request Jul 7, 2019
@bors
Auto merge of #62434 - Manishearth:clippyup, r=Manishearth
dbeed58 
Update clippy

r? @ghost
@bors

bors commented Jul 7, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: Manishearth
Pushing dbeed58 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2019
@bors bors merged commit e2885eb into rust-lang:master Jul 7, 2019
@rust-highfive

rust-highfive commented Jul 7, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #62434!

Tested on commit dbeed58.
Direct link to PR: #62434

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 7, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#62434!
906e819 
Tested on commit rust-lang/rust@dbeed58.
Direct link to PR: <rust-lang/rust#62434>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
@SimonSapin SimonSapin mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Manishearth @bors @matthiaskrgr @tesuji @Centril @rust-highfive