Remove horizontal lines at top of page by jsha · Pull Request #92797 · rust-lang/rust

jsha · 2022-01-11T23:35:03Z

They are not needed to separate the search bar and the title, which are visually distinct on their own.

Part of #59840

Demo: https://rustdoc.crud.net/jsha/fewer-lines/std/string/struct.String.html

r? @GuillaumeGomez

rust-highfive · 2022-01-11T23:35:06Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

camelid · 2022-01-12T02:55:16Z

Ah, what a nice improvement!

jsha · 2022-01-12T20:10:02Z

@bors retry

camelid · 2022-01-12T20:19:20Z

@jsha the test failure was not from bors, it was from PR CI. You can re-run that by clicking "re-run all jobs" on this page: https://github.com/rust-lang/rust/runs/4793628088?check_suite_focus=true. But it might not be worth it.

@bors r-

jsha · 2022-01-15T16:58:50Z

Bump on this one when you get a chance @GuillaumeGomez.

GuillaumeGomez · 2022-01-17T12:45:44Z

@jsha I don't think it's coming from your PR but just in case, can you rebase it on top of master please? Then r=me.

GuillaumeGomez · 2022-01-17T21:05:46Z

Thanks!

@bors: r+ rollup

bors · 2022-01-17T21:05:47Z

📌 Commit ddc328c159390d3562326993683349f57d451c69 has been approved by GuillaumeGomez

jsha · 2022-01-17T21:19:15Z

Thanks for the review! Temporarily bumping this out of the queue because it has a change to toggle-docs-mobile that will conflict with the changes in #92629. Letting that one merge first.

@bors r-

bors · 2022-01-18T10:05:13Z

☔ The latest upstream changes (presumably #93021) made this pull request unmergeable. Please resolve the merge conflicts.

camelid · 2022-01-18T23:48:05Z

@jsha should this be re-approved now or does it need a new review?

jsha · 2022-01-19T01:05:28Z

It shouldn't get reapproved quite yet. There's another PR in the queue (#92861) that also touches toggle-docs-mobile and will generate a conflict. Once that's landed I'll rebase this and reapprove it.

bors · 2022-01-19T02:37:36Z

☔ The latest upstream changes (presumably #93048) made this pull request unmergeable. Please resolve the merge conflicts.

They are not needed to separate the search bar and the title, which are visually distinct on their own.

jsha · 2022-01-19T03:48:48Z

@bors r=GuillaumeGomez rollup

I decided to make another revision on #92861, so it will need another review; this one can go ahead of it.

bors · 2022-01-19T03:48:49Z

📌 Commit fa9a843 has been approved by GuillaumeGomez

…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88642 (Formally implement let chains) - rust-lang#89621 (doc: guarantee call order for sort_by_cached_key) - rust-lang#91278 (Use iterator instead of recursion in `codegen_place`) - rust-lang#92124 (Little improves in CString `new` when creating from slice) - rust-lang#92783 (Annotate dead code lint with notes about ignored derived impls) - rust-lang#92797 (Remove horizontal lines at top of page) - rust-lang#92920 (Move expr- and item-related pretty printing functions to modules) - rust-lang#93041 (Remove some unused ordering derivations based on `DefId`) - rust-lang#93051 (Add Option::is_some_with and Result::is_{ok,err}_with) - rust-lang#93062 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rustdoc: remove dashed underline under main heading This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861. r? `@camelid`

rustdoc: remove dashed underline under main heading This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861. r? ``@camelid``

rustdoc: remove dashed underline under main heading This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861. r? ```@camelid```

jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 11, 2022

rust-highfive assigned GuillaumeGomez Jan 11, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2022

This comment has been minimized.

Sign in to view

jsha force-pushed the fewer-lines branch from 4a5466c to 386e781 Compare January 12, 2022 02:14

GuillaumeGomez reviewed Jan 12, 2022

View reviewed changes

Comment thread src/test/rustdoc-gui/headings.goml Outdated

jsha force-pushed the fewer-lines branch from 386e781 to ca4f960 Compare January 12, 2022 18:23

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2022

jsha force-pushed the fewer-lines branch from ca4f960 to 4ae9a40 Compare January 17, 2022 18:21

This comment has been minimized.

Sign in to view

jsha force-pushed the fewer-lines branch from 4ae9a40 to ddc328c Compare January 17, 2022 20:18

GuillaumeGomez approved these changes Jan 17, 2022

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 17, 2022

jsha force-pushed the fewer-lines branch from ddc328c to 4ecc74b Compare January 18, 2022 19:37

Remove horizontal lines at top of page

fa9a843

They are not needed to separate the search bar and the title, which are visually distinct on their own.

jsha force-pushed the fewer-lines branch from 4ecc74b to fa9a843 Compare January 19, 2022 02:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2022

matthiaskrgr mentioned this pull request Jan 19, 2022

Rollup of 10 pull requests #93069

Merged

jsha mentioned this pull request Jan 19, 2022

Controls and search in Rustdoc header are visually distracting #59840

Open

8 tasks

bors merged commit 7f2dbcb into rust-lang:master Jan 19, 2022

rustbot added this to the 1.60.0 milestone Jan 19, 2022

jsha mentioned this pull request Jan 21, 2022

rustdoc: remove dashed underline under main heading #93172

Merged

Uh oh!

Conversation

jsha commented Jan 11, 2022

Uh oh!

rust-highfive commented Jan 11, 2022

Uh oh!

This comment has been minimized.

camelid commented Jan 12, 2022

Uh oh!

Uh oh!

This comment has been minimized.

jsha commented Jan 12, 2022

Uh oh!

camelid commented Jan 12, 2022

Uh oh!

jsha commented Jan 15, 2022

Uh oh!

GuillaumeGomez commented Jan 17, 2022

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jan 17, 2022

Uh oh!

bors commented Jan 17, 2022

Uh oh!

jsha commented Jan 17, 2022

Uh oh!

bors commented Jan 18, 2022

Uh oh!

camelid commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsha commented Jan 19, 2022

Uh oh!

bors commented Jan 19, 2022

Uh oh!

jsha commented Jan 19, 2022

Uh oh!

bors commented Jan 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

camelid commented Jan 18, 2022 •

edited

Loading