Skip to content

Implement int extension#552

Open
sapir wants to merge 2 commits into
rust-lang:masterfrom
sapir:implement-int-extension
Open

Implement int extension#552
sapir wants to merge 2 commits into
rust-lang:masterfrom
sapir:implement-int-extension

Conversation

@sapir

@sapir sapir commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

I tried to fix the FIXME in zext. Would this be acceptable?

Also, how should I add tests?

@sapir sapir force-pushed the implement-int-extension branch from cc2bbb8 to 3f1304a Compare August 5, 2024 21:32
@antoyo

antoyo commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

For the test, you can either add it to this file or you can create another file in that directory.

@antoyo

antoyo commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Did you want to add a test or would you want to merge this as is?

@sapir

sapir commented Oct 13, 2024

Copy link
Copy Markdown
Contributor Author

I did try to add a test and found that the test passes either way, so maybe I should change the PR to just add the test instead of changing the code?

@antoyo

antoyo commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

You mean, to make sure the test fails without the implementation of int extension?
If so, yes, you can push a test, remove the implementation to make sure the test fails and push back the implementation.

@rustbot

rustbot commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #863) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants