Skip to content

fix(deploy): pipe deploy key directly to ssh-add to avoid temp file h…#768

Open
zulfff wants to merge 13 commits into
rust-lang:masterfrom
zulfff:fix-deploy-key-pipe
Open

fix(deploy): pipe deploy key directly to ssh-add to avoid temp file h…#768
zulfff wants to merge 13 commits into
rust-lang:masterfrom
zulfff:fix-deploy-key-pipe

Conversation

@zulfff

@zulfff zulfff commented Sep 3, 2025

Copy link
Copy Markdown

Pipe deploy key directly into ssh-add to avoid writing it on disk (@pietroalbini).

@emilyalbini emilyalbini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. CI is failing too.

Comment thread setup-deploy-keys/src/deploy.rs Outdated
Comment thread setup-deploy-keys/src/deploy.rs Outdated
Comment thread setup-deploy-keys/src/deploy.rs Outdated
@zulfff

zulfff commented Sep 22, 2025

Copy link
Copy Markdown
Author

Any updates?

@zulfff

zulfff commented Oct 4, 2025

Copy link
Copy Markdown
Author

helo

@zulfff

zulfff commented Oct 4, 2025

Copy link
Copy Markdown
Author

@pietroalbini

@Kobzol Kobzol requested a review from marcoieni November 9, 2025 09:18
@zulfff

zulfff commented Apr 1, 2026

Copy link
Copy Markdown
Author

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants