Skip to content

attempt to #[allow(unnecessary_transmutes)] in neon#1780

Merged
Amanieu merged 1 commit into
rust-lang:masterfrom
bend-n:what
Apr 17, 2025
Merged

attempt to #[allow(unnecessary_transmutes)] in neon#1780
Amanieu merged 1 commit into
rust-lang:masterfrom
bend-n:what

Conversation

@bend-n

@bend-n bend-n commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

im not sure why the #![allow] in lib.rs doesnt take effect, but for some reason it doesnt: rust-lang/rust#136083 (comment)

this might fix that? im not sure

@rustbot

rustbot commented Apr 17, 2025

Copy link
Copy Markdown
Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu

Amanieu commented Apr 17, 2025

Copy link
Copy Markdown
Member

lib.rs is only used for the core_arch tests. The standard library includes core_arch/src/mod.rs directly.

@bend-n

bend-n commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

oh so i should put the #![allow] in core_arch/src/mod.rs then, right?

@Amanieu

Amanieu commented Apr 17, 2025

Copy link
Copy Markdown
Member

Yes, that would be better.

@Amanieu

Amanieu commented Apr 17, 2025

Copy link
Copy Markdown
Member

The old allow in lib.rs should be removed since it is now redundant.

@Amanieu Amanieu enabled auto-merge April 17, 2025 18:00
@Amanieu Amanieu added this pull request to the merge queue Apr 17, 2025
Merged via the queue into rust-lang:master with commit 1245618 Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants