Skip to content

Prepare for lang FCPs in stdarch#2007

Merged
jieyouxu merged 1 commit into
rust-lang:masterfrom
traviscross:TC/prepare-for-lang-fcps-in-stdarch
Oct 13, 2025
Merged

Prepare for lang FCPs in stdarch#2007
jieyouxu merged 1 commit into
rust-lang:masterfrom
traviscross:TC/prepare-for-lang-fcps-in-stdarch

Conversation

@traviscross

@traviscross traviscross commented Oct 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Increasingly, due to what lives in stdarch, there's the likelihood of the lang team needing to do FCPs there. Let's arrange for that.

cc @rust-lang/lang @sayantn rust-lang/rust#146560

See, e.g., rust-lang/rust#146560 (comment).

This blocks rust-lang/stdarch#1935.

@traviscross
Prepare for lang FCPs in stdarch
dbbb35e 
Increasingly, due to what lives in stdarch, there's the likelihood of
the lang team needing to do FCPs there.  Let's arrange for that.
@traviscross traviscross force-pushed the TC/prepare-for-lang-fcps-in-stdarch branch from d3aaf11 to dbbb35e Compare October 1, 2025 21:56
@github-actions

github-actions Bot commented Oct 1, 2025

Copy link
Copy Markdown
Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/stdarch':
      Permission Changes:
        Giving team 'lang' write permission
        Giving team 'lang-ops' write permission
        Giving user 'rust-rfcbot' write permission

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Oct 2, 2025
jieyouxu
jieyouxu approved these changes Oct 2, 2025
View reviewed changes

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team-repo-admin approval given for team access changes, need an infra-admin approval for the bot changes.

nikomatsakis
nikomatsakis approved these changes Oct 2, 2025
View reviewed changes

@nikomatsakis nikomatsakis left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful. To be honest, I don't know why we do this on a repo-by-repo basis at all.

@traviscross traviscross mentioned this pull request Oct 5, 2025
Merged
@jieyouxu jieyouxu added this pull request to the merge queue Oct 13, 2025
Merged via the queue into rust-lang:master with commit a004d61 Oct 13, 2025
3 checks passed
@sayantn

sayantn commented Oct 13, 2025

Copy link
Copy Markdown

@traviscross so can I add T-lang-nominated to the stdarch pr now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

+4 more reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@joshtriplett joshtriplett joshtriplett approved these changes

@Amanieu Amanieu Amanieu approved these changes

@tmandry tmandry tmandry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@traviscross @sayantn @nikomatsakis @joshtriplett @Amanieu @tmandry @Mark-Simulacrum @jieyouxu