Skip to content

Personalize the Today view greeting#403

Open
Quaii wants to merge 5 commits into
ryanbr:mainfrom
Quaii:today-view-personalization
Open

Personalize the Today view greeting#403
Quaii wants to merge 5 commits into
ryanbr:mainfrom
Quaii:today-view-personalization

Conversation

@Quaii

@Quaii Quaii commented Jul 13, 2026

Copy link
Copy Markdown

What this PR does

This PR makes the Today view more welcoming, personal, and space-efficient across iOS and Android.

The time-based greeting previously shown above Synthesis is moved into the main header, replacing the generic “Today” title. Users can optionally provide their name during onboarding or later in Settings, producing greetings such as “Good evening, Alex.” When no name is provided, the localized greeting is shown without a comma.

The “Today” label is moved to the Synthesis section, where it now reads naturally alongside the current recovery and status indicators—for example, “Today · Rest · Solid.”

The top spacing is also reduced slightly. Because Today is the app’s primary screen, this makes more useful information visible immediately without making the layout feel cramped.

The existing Today quick-action button remains in place. This PR is standalone and does not depend on #397; that PR can replace the entry point independently if it is merged.

The optional name is included in backups while remaining compatible with existing backups that do not contain the new field.

Type of change

  • New feature
  • Refactor / cleanup

How it was tested

  • Rebased onto the current upstream main and confirmed that the PR is mergeable without Quick Launch files.
  • Built the NOOPiOS app successfully for the iOS Simulator with code signing disabled.
  • Manually tested the Today view in the iOS Simulator using example data.
  • Verified greetings with and without a preferred name.
  • Ran the focused ProfileGreetingTests — 3 tests passed.
  • Ran swift test in Packages/WhoopStore — 266 tests passed.
  • Ran ./gradlew testFullDebugUnitTest successfully.
  • Ran python3 Tools/i18n_audit.py --ci upstream/main successfully; Android and Apple UI-copy checks and the German, Spanish, and French catalog checks passed.
  • A broader StrandTests run executed 906 tests. The touched greeting tests passed; 26 unrelated BugReportTemplateTests assertions failed because the sandboxed test process could not read .github/ISSUE_TEMPLATE/bug_report.yml.
  • Android was implemented and unit-tested, but not manually tested on an Android device.
  • No BLE, protocol, or analytics behavior was changed.

Checklist

  • Swift package tests pass for any package I touched (swift test in Packages/<name>)
  • Android unit tests pass if I touched android/ (./gradlew testFullDebugUnitTest)
  • No new build warnings introduced
  • UI changes use only StrandDesign tokens — no hardcoded colors, fonts, or spacing
  • No hardcoded hex frame bytes; protocol facts live in the schema / decoders
  • Follows the conventions in docs/CONTRIBUTING.md
  • I did not commit generated output (Strand.xcodeproj/) or any secrets/keystores

Related issues

Independent of #397. That PR may later replace the existing Today quick-action entry point, but it is not required for this change.

image

@tigercraft4 tigercraft4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (external, non-blocking). Note on scope below — likely a stacked-branch artifact, not real creep.

Comment thread StrandiOS/App/QuickLaunchFavourites.swift Outdated
@Quaii
Quaii force-pushed the today-view-personalization branch 2 times, most recently from 4b37b9a to 750eaf0 Compare July 14, 2026 09:12
@Quaii

Quaii commented Jul 14, 2026

Copy link
Copy Markdown
Author

Resolved that it was not able to be merged after the new today reorder update.

@Quaii
Quaii requested a review from tigercraft4 July 14, 2026 10:26
@Quaii
Quaii force-pushed the today-view-personalization branch from 750eaf0 to 6cc5a28 Compare July 18, 2026 17:26
@Quaii

Quaii commented Jul 18, 2026

Copy link
Copy Markdown
Author

Resolved the conflicts

@Quaii
Quaii force-pushed the today-view-personalization branch from 6cc5a28 to 2bf4339 Compare July 20, 2026 10:01
Quaii added 3 commits July 24, 2026 19:10
# Conflicts:
#	android/app/src/main/res/values-de/strings.xml
#	android/app/src/main/res/values-es/strings.xml
#	android/app/src/main/res/values-fr/strings.xml
#	android/app/src/main/res/values/strings.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants