Settings: move HRV tuning to Advanced, add a shared info-popover#518
Open
digitalerdude wants to merge 6 commits into
Open
Settings: move HRV tuning to Advanced, add a shared info-popover#518digitalerdude wants to merge 6 commits into
digitalerdude wants to merge 6 commits into
Conversation
Strap and Features stayed always-visible and mixed everyday connection controls with power-user tuning (Continuous HRV capture, HRV window) and long paragraph captions under every toggle — overwhelming for a first-time user. Continuous HRV capture + HRV window move into a new "HRV" card under the already-collapsed Advanced disclosure (same bindings, no behavior change); the long "nice to know" captions across Strap/Features become a tap-to-reveal (i) popover via a new shared InfoButton (StrandDesign), while any safety/battery-impact sentence stays inline. The strap-log button and strap name/Live Activity controls stay in Strap as-is (ryanbr#507/ryanbr#509). Verified: xcodebuild for Strand (macOS), NOOPiOS (iOS Simulator) and NOOPWatch (watchOS Simulator) all build clean; swift build/test passes for StrandDesign.
…age gate) The Strap/HRV/Features caption split in the prior commit introduced new literal Text(...) strings (shorter inline sentences, split off the original paragraphs) that aren't in the catalog yet, so the i18n-coverage gate flags them as un-extracted. Add de/es/fr entries for the 6 new literals, lifted from the existing translations of the original combined paragraphs they were split from (the wording overlaps almost verbatim in most cases). i18n_audit.py --ci origin/main: OK, no un-extracted literals.
digitalerdude
marked this pull request as ready for review
July 17, 2026 05:29
…ter-advanced # Conflicts: # Strand/Resources/Localizable.xcstrings # Strand/Screens/SettingsView.swift
…ter-advanced # Conflicts: # Strand/Resources/Localizable.xcstrings
…ter-advanced # Conflicts: # Strand/Resources/Localizable.xcstrings
…ter-advanced # Conflicts: # Strand/Resources/Localizable.xcstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@AppStoragebindings, same BLE/re-score wiring — no behavior change, just relocated). Advanced's subtitle now mentions "HRV tuning" so anyone who goes looking finds it.InfoButtoninStrandDesign(modeled onSleepView's existing nap-row popover idiom). Any sentence describing a safety or battery-impact consequence stays inline as visible text — only background/context prose moves behind the (i).SettingsSection/FormRowgained an optional trailingaccessoryslot (genericAccessory: View+Accessory == EmptyViewextension, same pattern asStatTileinComponents.swift), so every existing call site keeps compiling unchanged.Pure SwiftUI/macOS+iOS change — no server/analytics/migration/stored-value crossing the
.noopbakboundary, so no Android parity change is required in this PR (Android's Settings has no popover equivalent yet; porting the pattern there is a separate design decision, not a mechanical port).Test plan
xcodebuild -scheme Strand -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO build— succeedsxcodebuild -scheme NOOPiOS -destination 'platform=iOS Simulator,name=iPhone 17' build— succeedsxcodebuild -scheme NOOPWatch -destination 'generic/platform=watchOS Simulator' build— succeeds (confirms the#if !os(watchOS)guard onInfoButtonis correct, not a silent skip)cd Packages/StrandDesign && swift build && swift test— succeeds, 0 failures