Add personalized HR zone thresholds (#138)#531
Open
kavemang wants to merge 2 commits into
Open
Conversation
kavemang
marked this pull request as ready for review
July 16, 2026 21:30
kavemang
marked this pull request as draft
July 16, 2026 21:40
kavemang
marked this pull request as ready for review
July 16, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138.
What changed
.noopbaksettings backupsWhy
The existing max-HR override helps users whose measured maximum differs from the age estimate, but it cannot represent lab- or threshold-derived training zones such as LT1/LT2. Personalized BPM boundaries provide that control without changing Effort/strain calculations or any stored workout data.
Safety and compatibility
Validation
./gradlew testFullDebugUnitTest— passespython3 Tools/i18n_audit.py --ci upstream/main— passesgit diff --check— passesSwift Packages CI— passes, includingStrandAnalyticsandWhoopStore