Skip to content

feat(dns): record per-query inspection timing #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanfowler merged 1 commit into from
Aug 30, 2026
Merged

feat(dns): record per-query inspection timing #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/dnsinspect/dnsinspect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ func runFanOut(ctx context.Context, host string, target resolverTargetInfo, syst
wg.Add(1)
go func(i int, qt queryType) {
defer wg.Done()
queryStart := time.Now()
results[i].typ = qt
switch {
case systemPolicy != nil:
Expand All @@ -410,6 +411,14 @@ func runFanOut(ctx context.Context, host string, target resolverTargetInfo, syst
default:
results[i].records, results[i].tcpFallback, results[i].err = lookupUDPRecordsWithFallback(ctx, target.udpAddr, host, qt)
}
// System-nameserver queries expose resolver metadata that includes
// failover and retry time. The other backends do not, so measure
// their query operation here. This starts after shared resolver
// setup, which prevents bootstrap/connect time from being charged
// to every concurrently issued query.
if results[i].duration <= 0 {
results[i].duration = time.Since(queryStart)
}
}(i, qt)
}
wg.Wait()
Expand Down
10 changes: 9 additions & 1 deletion internal/dnsinspect/dnsinspect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func TestLookupQueriesRecordTypesConcurrently(t *testing.T) {
}))
defer server.Close()

_, err := lookup(context.Background(), &Config{
res, err := lookup(context.Background(), &Config{
DNSServer: mustURL(t, server.URL+"/dns-query"),
}, "example.com", time.Now())
if err != nil {
Expand All @@ -360,6 +360,14 @@ func TestLookupQueriesRecordTypesConcurrently(t *testing.T) {
if got < 2 {
t.Fatalf("max concurrent requests = %d, want at least 2", got)
}
if got, want := len(res.queries), len(inspectTypes); got != want {
t.Fatalf("query results = %d, want %d", got, want)
}
for _, query := range res.queries {
if query.duration <= 0 {
t.Errorf("%s query duration = %s, want positive duration", query.typ.label, query.duration)
}
}
}

func TestInspectKeepsRecordsAndFailsOnPartialQueryError(t *testing.T) {
Expand Down
Loading