Skip to content

fix: stop fake protoc child recursion - #1166

Merged
ryanfowler merged 1 commit into
mainfrom
fix/windows-protoc-child-pid-race
Aug 30, 2026
Merged

fix: stop fake protoc child recursion#1166
ryanfowler merged 1 commit into
mainfrom
fix/windows-protoc-child-pid-race

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • dispatch the fake protoc child worker from its command-line argument before checking the inherited test mode
  • prevent recursive child creation and concurrent PID-file truncation in the Windows containment test
  • preserve the intended inherited-pipe containment coverage

Testing

  • go test -v ./internal/proto
  • go test -parallel 8 ./...
  • GOOS=windows CGO_ENABLED=0 go test -c ./internal/proto
  • git diff --check

@ryanfowler
ryanfowler enabled auto-merge August 30, 2026 20:35
@ryanfowler
ryanfowler merged commit 66d5cad into main Aug 30, 2026
12 checks passed
@ryanfowler
ryanfowler deleted the fix/windows-protoc-child-pid-race branch August 30, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant