Skip to content

fix(http): keep request URL normalization reusable - #1169

Merged
ryanfowler merged 1 commit into
mainfrom
fix/request-url-normalization
Aug 30, 2026
Merged

fix(http): keep request URL normalization reusable#1169
ryanfowler merged 1 commit into
mainfrom
fix/request-url-normalization

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • validate missing request URLs instead of panicking during request construction
  • normalize schemes and query parameters on a per-request URL copy so repeated requests do not accumulate state
  • retain the effective URL privately for post-failure diagnostics and recognize Go 1.27 HTTP/HTTPS scheme mismatches
  • add unit and integration coverage for request reuse and plaintext-service hints

Testing

  • go test -v -parallel 8 ./...
  • go test -race ./internal/client ./internal/fetch
  • go build .
  • CGO_ENABLED=0 go build .
  • go mod tidy && go mod verify
  • staticcheck ./...

@ryanfowler
ryanfowler merged commit 71fc0ed into main Aug 30, 2026
12 checks passed
@ryanfowler
ryanfowler deleted the fix/request-url-normalization branch August 30, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant