Skip to content

Improve HTTP request and response correctness - #1171

Merged
ryanfowler merged 1 commit into
mainfrom
improve-http-request-response
Aug 30, 2026
Merged

Improve HTTP request and response correctness#1171
ryanfowler merged 1 commit into
mainfrom
improve-http-request-response

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary:

  • validate request framing headers before connecting, including body-length consistency and transport-representable framing
  • retry additional transient HTTP statuses while avoiding retries for DNS name-not-found failures
  • use decoded response length for download progress so compressed downloads do not exceed 100 percent
  • document the updated header and retry behavior

Testing:

  • GOCACHE=/tmp/fetch-gocache go test -parallel 8 ./...
  • XDG_CACHE_HOME=/tmp/fetch-xdg-cache GOCACHE=/tmp/fetch-gocache staticcheck ./...
  • GOCACHE=/tmp/fetch-gocache CGO_ENABLED=0 go build -o /tmp/fetch-pr-build .
  • GOCACHE=/tmp/fetch-gocache go mod verify

Review:

  • completed three independent subagent review rounds
  • addressed all actionable feedback, including wire-level framing tests

@ryanfowler
ryanfowler merged commit 0495609 into main Aug 30, 2026
12 checks passed
@ryanfowler
ryanfowler deleted the improve-http-request-response branch August 30, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant