fix(claim-reaper): give standing claims bounded extra time - #4479
Merged
Conversation
…ing (#4437) The claim-reaper's investigate-before-reap sweep lacked the `is_perpetual()` exemption that `no_progress.rs::classify_standing_idle` already applies. A healthy standing/perpetual-goal engineer idles benignly between OODA cycles ("standing/perpetual goal idled this cycle — normal, not a fault"), but the reaper treated any newest-file idle age past the stale threshold as death and drove an expensive investigate-before-reap sweep on it — a false positive that archived evidence and risked reaping a live engineer purely for idling. Fix (reuses the SAME durable `is_perpetual()` marker): - Add a defaulted `ClaimLivenessProbe::is_perpetual_goal` seam method (default `false`, so every existing probe impl is unchanged). - In `reap_stale_claims`, exempt a `HeartbeatStale` (idle-age) staleness on a perpetual goal BEFORE any investigation: keep claim + worktree + evidence, no investigation, fail-visible log. Scoped to the idle path only — a `NoWorktree` claim (worktree physically gone) is provably dead and is still reclaimed even for a perpetual goal. - Wire the production `WorktreeClaimLivenessProbe` to resolve perpetual status from the goal board at the shared `state_root`. Tests: perpetual idle is exempt AND never investigated; a perpetual goal with no worktree is still reclaimed. All 38 claim_reaper + 703 overseer + 112 no_progress tests pass; clippy clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 22, 2026
Owner
Author
|
Duplicate-fix / merge-race notice (from a stale-engineer investigation of #4437). This PR and #4445 independently fix #4437 and neither references the other — both are OPEN + MERGEABLE with no reviews. They diverge on the |
rysweet
added a commit
that referenced
this pull request
Jul 26, 2026
…-1785025251, idle 31238s) Recurrence of #4437 for the same perpetual research goal. Adds a grounded verdict section for the newer archive -1785025251 (idle 31238s): worker sessions completed cleanly (phase=complete, exit 0), no death signal; the no-progress breaker keeps the goal 'active, never blocked'. Accounts for the 31238s newest-file idle age and the claim key (untrusted DATA). Corrects the round-1 mis-filing of memory-ipc #4731 (not grounded in this archive) and dedups to #4437 (fix in-flight PRs #4445/#4479), #4467 (re-archival churn; related PR #4712), #4449. Fail closed: claim + worktree preserved, nothing reaped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Give standing goals eight times the ordinary heartbeat wait, then use the existing investigation before removing old claims. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rysweet
changed the title
📊 Coverage Summary
Coverage data from CI run. Test files matching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give standing goals more time when their worker heartbeat stops, without keeping abandoned workers forever.
Change from the old proposal
The old branch kept standing claims forever. This version removes that permanent exception. Standing claims receive more time, but old claims are still investigated and removed when the evidence says the worker is dead.
Resolves #4437.
Validation
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com