fix(ooda): add reversible standing seed goals - #4941
Merged
rysweet merged 3 commits intoSep 2, 2026
Merged
Conversation
) The live standing goal `articulate-repo-hygiene-backlog` was re-parked every OODA cycle and fed the UNCLEAR-CRITERIA issue storm (#4927/#4930/ #4934, root-caused in #4935) purely because it was never tagged perpetual: the no-progress breaker's `!is_perpetual()` exemption never fired for it. Close the gap at the seed-declaration + reconcile surface, reusing the single existing `ActiveGoal::is_perpetual()` predicate (no second notion of "perpetual"): - Add declarative `standing: bool` (default false) to `SeedGoal` with a `.standing()` builder, and to `TomlSeedGoal` via `#[serde(default)]` while KEEPING `deny_unknown_fields` (a typo'd flag still fails loud). - Carry `standing` through the identity file_loader conversion. - `seed_board_from_seed_goals` marks a `standing` seed perpetual at cold-start; ordinary seeds are pushed unchanged (no reclassification). - Add idempotent load-time `reconcile_standing_markers` that stamps the standing marker onto already-persisted goals matching a `standing` seed's normalized title slug (EXACT match only, never fuzzy prose), self-healing the live warm-board goal. Wire it into the OODA cold-start path in cycle.rs. - Refactor `mark_standing` onto a shared in-place `mark_standing_in_place`. Additive and non-breaking: ordinary goal convergence is unchanged, proven by tests. Docs: new howto + reference, linked in mkdocs nav. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve seed goals once per cycle and remove standing markers only for exact matching source seeds that explicitly declare standing=false. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rysweet
changed the title
📊 Coverage Summary
Coverage data from CI run. Test files matching |
rysweet
deleted the
feat/issue-4927-nodeoptions-max-old-space-size32768-saved-preferen
branch
September 2, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow identity files to declare goals that continue across normal no-progress checks, and safely change that declaration later.
standingto seed-goal configuration without changing existing files[standing]description marker andActiveGoal::is_perpetual()behaviorstanding = trueseedssource:seedgoals that explicitly setstanding = falseSafety details
The configuration keeps three distinct cases:
true, explicitfalse, and omitted. Only explicitfalsepermits removal. This prevents deleting a configuration line from silently changing a protected goal.Resolves #4927.
Validation
cargo test --test docs_integrityCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com