presetBrowser: swap detail status and action styles - #84
Open
ptn wants to merge 1 commit into
Open
Conversation
The Grid/Params/Versions elements looked like they were clickable, cause they were outlined in accent, but they aren't buttons. They are indicators of what loadDetail() has hydrated. Meanwhile the row that is interactive (Load preset / Audition / Refresh detail / Convert) read as less prominent. I tried to click the status row. Swap them: - Status becomes a dot-and-label strip following the existing .gate and .leg precedent — dot inherits currentColor, --textfaint when pending, --ok when loaded. Accent is dropped here; it is the app's active signal and a main reason the row read as tabs. - .load-action takes the vacated mono/uppercase/letter-spaced treatment and gains :hover and :focus-visible, reusing the .preset-row precedent. Grid floor 104px -> 124px so OPEN IN CONVERTER fits. - The .runtime-detail block restated the same three facts in prose; removed, with its wording moved into each item's title/aria-label and the version count folded into the label. .runtime-error is untouched. The label/title derivation moves to presetBrowserWorkbenchDetailStatus.ts so it is unit-testable — Vitest runs in node with no DOM and .svelte files are never mounted. data-status/data-loaded/data-action attributes are added for a future e2e spec, which needs a preset-library mock in the mold of gridMock.ts and is deliberately out of scope here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Grid/Params/Versions elements looked like they were clickable, but they aren't, they are indicators of what loadDetail() has hydrated. Meanwhile the row that is interactive (Load preset / Audition / Refresh detail / Convert) read as less prominent. I tried to click the status row.
Changes to the former
They are now very visibly status indicators:
Before:
After:
Changes to the latter (buttons)
Before:
After:
Release
Merging to
mainreleases automatically — a singlerelease:*label controls it:docs/,.github/, or*.md→ no release)release:minor/release:major→ bigger bumprelease:none→ adopt without releasing (rides the next release)release:hold→ merge now, release laterrelease:hold/release:nonewin over a co-present bump labelpr-labelscheck enforces this)Versions come from tags — never bump
package.jsonin a PR. This repo releases with the-betasuffix (X.Y.Z-beta).Details: docs/RELEASING.md