Skip to content

deviceCache: match block-hi/param-hi in walk reply-pairing (Phase-1 in-app 100%) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sKuhLight merged 1 commit into from
Jul 16, 2026
Merged

deviceCache: match block-hi/param-hi in walk reply-pairing (Phase-1 in-app 100%) #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "forgefx-server",
"version": "0.6.26-beta",
"version": "0.6.28-beta",
"private": true,
"description": "ForgeFX — open HTTP API for Fractal devices. Node backend powered by fractal-midi.",
"license": "MIT",
Expand Down
7 changes: 6 additions & 1 deletion server/src/services/deviceCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,13 @@ const WALK_MAX_PARAM_ID = 127;
function adaptRequest(transport: Transport, query: Uint8Array): Promise<Uint8Array | null> {
const bytes = Array.from(query);
const fn = bytes[5];
// Match the fn AND every echoed address byte: view f[6], block-lo f[8] + block-hi
// f[9] (effectId>=128), param-lo f[10] + param-hi f[11] (id>127). Matching only
// view+param-lo (the old code) can pair a high-block/high-param query with a stale
// reply for a different block/param — a desync that turns a slowdown into a wedge.
const isEcho = (f: readonly number[]): boolean =>
isFractalHeaderFrame(f) && f[5] === fn && f[6] === bytes[6] && f[10] === bytes[10];
isFractalHeaderFrame(f) && f[5] === fn && f[6] === bytes[6]
&& f[8] === bytes[8] && f[9] === bytes[9] && f[10] === bytes[10] && f[11] === bytes[11];
return transport
.request(bytes, { timeoutMs: 1000, quietMs: 20, match: (fs) => fs.some((f) => isEcho(f)) })
.then((frames) => {
Expand Down
Loading